Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/browser/chromeos/login/test/oobe_base_test.cc

Issue 1987053003: Wait for OobeWebUI to finish loading before running tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/test/oobe_base_test.cc
diff --git a/chrome/browser/chromeos/login/test/oobe_base_test.cc b/chrome/browser/chromeos/login/test/oobe_base_test.cc
index 5d5a5278d5e29daf932a66ab9713c5751b4346d0..52d6f6cc47999f7d2911e3dfed2e14abc0ad2add 100644
--- a/chrome/browser/chromeos/login/test/oobe_base_test.cc
+++ b/chrome/browser/chromeos/login/test/oobe_base_test.cc
@@ -7,6 +7,7 @@
#include "base/command_line.h"
#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
+#include "base/run_loop.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/chromeos/login/existing_user_controller.h"
#include "chrome/browser/chromeos/login/session/user_session_manager.h"
@@ -111,6 +112,13 @@ void OobeBaseTest::SetUpOnMainThread() {
LoginDisplayHostImpl::DisableRestrictiveProxyCheckForTest();
+ // Wait for OobeUI to finish loading.
+ base::RunLoop run_loop;
+ if (!LoginDisplayHost::default_host()->GetOobeUI()->IsJSReady(
+ run_loop.QuitClosure())) {
+ run_loop.Run();
+ }
+
ExtensionApiTest::SetUpOnMainThread();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698