Updates to collection_patch.dart

Updates to collection_patch.dart

BUG=
R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/2d17e72ba5dd75740b97f9726ee55d39ee18fb63

[sra1, 2016-05-18 02:55:03]

sra@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2016-05-18 20:11:54]

lgtm

https://codereview.chromium.org/1987043002/diff/40001/tool/input_sdk/patch/co...
File tool/input_sdk/patch/collection_patch.dart (right):

https://codereview.chromium.org/1987043002/diff/40001/tool/input_sdk/patch/co...
tool/input_sdk/patch/collection_patch.dart:222: List/*<K>*/ result = new
List/*<K>*/(_length);
consider var?

https://codereview.chromium.org/1987043002/diff/40001/tool/input_sdk/patch/co...
tool/input_sdk/patch/collection_patch.dart:434: class _HashMapKeyIterable<K, V>
extends Iterable<K> implements EfficientLength {
If you get rid of V in the iterator, I don't think you need it here either.

https://codereview.chromium.org/1987043002/diff/40001/tool/input_sdk/patch/co...
tool/input_sdk/patch/collection_patch.dart:460: class _HashMapKeyIterator<K, V>
implements Iterator<K> {
Why do you need V?  It never appears in the interface.  The only use is on the
type of _map, so you could just make that _HashMap<K, dynamic>.

[sra1, 2016-05-18 22:10:04]

https://codereview.chromium.org/1987043002/diff/40001/tool/input_sdk/patch/co...
File tool/input_sdk/patch/collection_patch.dart (right):

https://codereview.chromium.org/1987043002/diff/40001/tool/input_sdk/patch/co...
tool/input_sdk/patch/collection_patch.dart:222: List/*<K>*/ result = new
List/*<K>*/(_length);
On 2016/05/18 20:11:54, Leaf wrote:
> consider var?

Done.

https://codereview.chromium.org/1987043002/diff/40001/tool/input_sdk/patch/co...
tool/input_sdk/patch/collection_patch.dart:434: class _HashMapKeyIterable<K, V>
extends Iterable<K> implements EfficientLength {
On 2016/05/18 20:11:53, Leaf wrote:
> If you get rid of V in the iterator, I don't think you need it here either.

Done.

https://codereview.chromium.org/1987043002/diff/40001/tool/input_sdk/patch/co...
tool/input_sdk/patch/collection_patch.dart:460: class _HashMapKeyIterator<K, V>
implements Iterator<K> {
On 2016/05/18 20:11:53, Leaf wrote:
> Why do you need V?  It never appears in the interface.  The only use is on the
> type of _map, so you could just make that _HashMap<K, dynamic>.

Done.

[sra1, 2016-05-18 22:10:49]

Description was changed from

==========
Updates to collection_patch.dart

BUG=
==========

to

==========
Updates to collection_patch.dart

BUG=
R=leafp@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/2d17e72ba5dd75740b97f9726ee5...
==========

[sra1, 2016-05-18 22:10:50]

Committed patchset #3 (id:40001) manually as
2d17e72ba5dd75740b97f9726ee55d39ee18fb63 (presubmit successful).