Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 198703006: Move ExtensionHost from src/chrome to src/extensions (Closed)

Created:
6 years, 9 months ago by James Cook
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, markusheintz_, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, vsevik, aboxhall+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, yuzo+watch_chromium.org, paulirish+reviews_chromium.org, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, plundblad+watch_chromium.org, tfarina, yurys, robertshield, davemoore+watch_chromium.org, dtseng+watch_chromium.org, pfeldman, Ken Rockot(use gerrit already)
Visibility:
Public.

Description

Move ExtensionHost from src/chrome to src/extensions This breaks another src/extensions -> src/chrome dependency. * Mechanical file move. * Clean up DEPS. * Move pinch-to-zoom handling to ExtensionViewHost as it only applies to visible extension content. No functional changes. BUG=321341 TEST=browser_tests *Extension* TBR=sky@chromium.org for header file rename across chrome/browser Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -708 lines) Patch
M apps/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M apps/app_lifetime_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_load_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_restore_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_shim/extension_app_shim_handler_mac.cc View 2 chunks +1 line, -1 line 0 comments Download
M apps/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/saved_files_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_target_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/alert_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/extension_message_port.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browsertest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/devtools_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_host.h View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/extensions/extension_host.cc View 1 chunk +0 lines, -441 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_view_host.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_view_host.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/gpu_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/gtalk_extension_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/process_management_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/extension_process_resource_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/api_resource_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/extension_host.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/extension_host.cc View 4 chunks +1 line, -12 lines 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/process_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
James Cook
yoz, can you rubber-stamp this? The only non-mechanical changes are the DEPS cleanup and moving ...
6 years, 9 months ago (2014-03-20 20:36:45 UTC) #1
Yoyo Zhou
LGTM, awesome
6 years, 9 months ago (2014-03-20 21:21:37 UTC) #2
James Cook
+rockot just as FYI. This might conflict with your patch https://codereview.chromium.org/201203006/ - we'll see who ...
6 years, 9 months ago (2014-03-20 22:05:19 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-20 22:05:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/198703006/1
6 years, 9 months ago (2014-03-20 22:06:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 22:12:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 22:12:42 UTC) #7
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-20 22:14:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/198703006/1
6 years, 9 months ago (2014-03-20 22:16:38 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 01:39:02 UTC) #10
Message was sent while issue was closed.
Change committed as 258494

Powered by Google App Engine
This is Rietveld 408576698