Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html

Issue 198703004: [CSS Grid Layout] Fix issues adding new items to grid (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@enable-css-grid-layout
Patch Set: Keep else, improve comment and change param in growGrid() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html b/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html
index 5c6f50d13af03fa74d43ec63d7d6cd0d54f6b00d..0bb063920f04ec043ca2201f945af526d212d253 100644
--- a/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html
+++ b/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html
@@ -21,30 +21,31 @@ function testAddition(gridElementID, position, autoFlowElementID, size)
var autoFlowElement = document.getElementById(autoFlowElementID);
autoFlowElement.setAttribute("data-expected-width", size.width);
autoFlowElement.setAttribute("data-expected-height", size.height);
- checkLayout("#" + autoFlowElementID);
+ checkLayout("#" + autoFlowElementID, document.getElementById("test-output"));
}
function testAdditions()
{
- checkLayout("#autoFlowColumnElement");
+ var testOutput = document.getElementById("test-output");
+ checkLayout("#autoFlowColumnElement", testOutput);
testAddition("gridAutoFlowColumn", { 'row': '1', 'column': '1' }, "autoFlowColumnElement", { 'width': '50', 'height': '100' });
testAddition("gridAutoFlowColumn", { 'row': '1', 'column': '2' }, "autoFlowColumnElement", { 'width': '50', 'height': '100' });
testAddition("gridAutoFlowColumn", { 'row': '2', 'column': '2' }, "autoFlowColumnElement", { 'width': '50', 'height': '100' });
testAddition("gridAutoFlowColumn", { 'row': '2', 'column': '1' }, "autoFlowColumnElement", { 'width': '170', 'height': '50' });
- checkLayout("#autoFlowRowElement");
+ checkLayout("#autoFlowRowElement", testOutput);
testAddition("gridAutoFlowRow", { 'row': '1', 'column': '1' }, "autoFlowRowElement", { 'width': '100', 'height': '50' });
testAddition("gridAutoFlowRow", { 'row': '2', 'column': '1' }, "autoFlowRowElement", { 'width': '100', 'height': '50' });
testAddition("gridAutoFlowRow", { 'row': '2', 'column': '2' }, "autoFlowRowElement", { 'width': '100', 'height': '50' });
testAddition("gridAutoFlowRow", { 'row': '1', 'column': '2' }, "autoFlowRowElement", { 'width': '50', 'height': '30' });
- checkLayout("#gridAutoFlowColumnWithAuto");
+ checkLayout("#gridAutoFlowColumnWithAuto", testOutput);
testAddition("gridAutoFlowColumnWithAuto", { 'row': 'auto', 'column': '1' }, "autoFlowColumnElementWithAuto", { 'width': '50', 'height': '100' });
testAddition("gridAutoFlowColumnWithAuto", { 'row': '1', 'column': '1' }, "autoFlowColumnElementWithAuto", { 'width': '100', 'height': '50' });
testAddition("gridAutoFlowColumnWithAuto", { 'row': 'auto', 'column': '2' }, "autoFlowColumnElementWithAuto", { 'width': '100', 'height': '100' });
testAddition("gridAutoFlowColumnWithAuto", { 'row': '2', 'column': '2' }, "autoFlowColumnElementWithAuto", { 'width': '170', 'height': '50' });
- checkLayout("#gridAutoFlowRowWithAuto");
+ checkLayout("#gridAutoFlowRowWithAuto", testOutput);
testAddition("gridAutoFlowRowWithAuto", { 'row': '1', 'column': 'auto' }, "autoFlowRowElementWithAuto", { 'width': '100', 'height': '50' });
testAddition("gridAutoFlowRowWithAuto", { 'row': 'auto', 'column': '1' }, "autoFlowRowElementWithAuto", { 'width': '100', 'height': '50' });
testAddition("gridAutoFlowRowWithAuto", { 'row': '1', 'column': '2' }, "autoFlowRowElementWithAuto", { 'width': '50', 'height': '100' });
@@ -80,5 +81,7 @@ window.addEventListener("load", testAdditions, false);
</div>
</div>
+<div id="test-output"></div>
+
</body>
</html>
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698