Add GL_TEXTURE_EXTERNAL_OES as supported texture target for CHROMIUM_map_image.

ui/gl/gl_image_egl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_image_egl.h"
 
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_surface_egl.h"
 
 namespace gfx {
 
 GLImageEGL::GLImageEGL(gfx::Size size)
     : egl_image_(EGL_NO_IMAGE_KHR),
       size_(size),
       release_after_use_(false),
       in_use_(false),
-      target_(0) {
-}
+      target_(0),
+      native_buffer_(0) {}
 
 GLImageEGL::~GLImageEGL() {
   Destroy();
 }
 
 bool GLImageEGL::Initialize(gfx::GpuMemoryBufferHandle buffer) {
   DCHECK(buffer.native_buffer);
+  native_buffer_ = buffer.native_buffer;

[reveman, 2014/03/19 18:17:30]

are you sure buffer.native_buffer is a valid pointer after this function
returns? Even if that happens to be the case, I'm not sure it's appropriate to
hold on to it here.

   EGLint attrs[] = {
     EGL_IMAGE_PRESERVED_KHR, EGL_TRUE,
     EGL_NONE,
   };
-  egl_image_ = eglCreateImageKHR(
-      GLSurfaceEGL::GetHardwareDisplay(),
-      EGL_NO_CONTEXT,
-      EGL_NATIVE_BUFFER_ANDROID,
-      buffer.native_buffer,
-      attrs);
+  egl_image_ = eglCreateImageKHR(GLSurfaceEGL::GetHardwareDisplay(),
+                                 EGL_NO_CONTEXT,
+                                 EGL_NATIVE_BUFFER_ANDROID,
+                                 native_buffer_,
+                                 attrs);
 
   if (egl_image_ == EGL_NO_IMAGE_KHR) {
     EGLint error = eglGetError();
     LOG(ERROR) << "Error creating EGLImage: " << error;
     return false;
   }
 
   return true;
 }
 
@@ skipping 55 matching lines @@
   DCHECK_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
 }
 
 void GLImageEGL::DidUseTexImage() {
   DCHECK(in_use_);
   in_use_ = false;
 
   if (!release_after_use_)
     return;
 
-  char zero[4] = { 0, };
-  glTexImage2D(target_,
-               0,
-               GL_RGBA,
-               1,
-               1,
-               0,
-               GL_RGBA,
-               GL_UNSIGNED_BYTE,
-               &zero);
+  EGLint attrs[] = {EGL_IMAGE_PRESERVED_KHR, EGL_TRUE, EGL_NONE, };
+  EGLImageKHR egl_image = eglCreateImageKHR(GLSurfaceEGL::GetHardwareDisplay(),
+                                            EGL_NO_CONTEXT,
+                                            EGL_NATIVE_BUFFER_ANDROID,
+                                            native_buffer_,
+                                            attrs);
+  DCHECK_NE(EGL_NO_IMAGE_KHR, egl_image)
+      << "Error creating EGLImage: " << eglGetError();
+  glEGLImageTargetTexture2DOES(target_, egl_image);

[reveman, 2014/03/19 18:17:30]

I don't understand why this would work. Binding the same native buffer again
releases it? Please explain how this works.

+  DCHECK_EQ(static_cast<GLenum>(GL_NO_ERROR), glGetError());
+  EGLBoolean status =
+      eglDestroyImageKHR(GLSurfaceEGL::GetHardwareDisplay(), egl_image);

[boliu, 2014/03/20 10:57:29]

Currently this destroy fails.

+  if (status == EGL_FALSE) {
+    EGLint error = eglGetError();
+    LOG(ERROR) << "Error destroying EGLImage: " << error;
+  }
 }
 
 void GLImageEGL::WillModifyTexImage() {
 }
 
 void GLImageEGL::DidModifyTexImage() {
 }
 
 void GLImageEGL::SetReleaseAfterUse() {
   release_after_use_ = true;
 }
 
 }  // namespace gfx