third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp - Issue 1987013002: Add UMA to track time between preload discovery and reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

Issue 1987013002: Add UMA to track time between preload discovery and reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@preload_timing_uma

Patch Set: Include preloads generated by LinkLoader Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/FetchRequest.h ('K') | « third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp ('k') | third_party/WebKit/Source/core/loader/LinkLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

index dff65e3e298a299c93a3726db1ac60920224bcfb..efa3ff9888501b7820794455df1864f89eff6acd 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

@@ -75,7 +75,7 @@ void HTMLResourcePreloader::preload(PassOwnPtr<PreloadRequest> preload, const Ne

return;

if (preload->resourceType() == Resource::Script || preload->resourceType() == Resource::CSSStyleSheet || preload->resourceType() == Resource::ImportResource)

request.setCharset(preload->charset().isEmpty() ? m_document->characterSet().getString() : preload->charset());

- request.setForPreload(true);

+ request.setForPreload(true, preload->discoveryTime());

int duration = static_cast<int>(1000 * (monotonicallyIncreasingTime() - preload->discoveryTime()));

DEFINE_STATIC_LOCAL(CustomCountHistogram, preloadDelayHistogram, ("WebCore.PreloadDelayMs", 0, 2000, 20));

preloadDelayHistogram.count(duration);