Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: runtime/bin/vmservice/service_request.dart

Issue 19870006: Support stacktrace and objecthistogram service commands (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/bin/vmservice/service_request_router.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/service_request.dart
diff --git a/runtime/bin/vmservice/service_request.dart b/runtime/bin/vmservice/service_request.dart
index 83f26db03a728e372ee76f3a9c51e99ea74bd7d3..04bf3975db4ee8a16d02c5d7b185c5335427f8ba 100644
--- a/runtime/bin/vmservice/service_request.dart
+++ b/runtime/bin/vmservice/service_request.dart
@@ -31,17 +31,14 @@ class ServiceRequest {
return true;
}
- String toServiceCallMessage() {
- return JSON.stringify({
- 'p': pathSegments,
- 'k': parameters.keys.toList(),
- 'v': parameters.values.toList()
- });
+ List toServiceCallMessage() {
+ return [pathSegments, parameters.keys.toList(), parameters.values.toList()];
}
void setErrorResponse(String error) {
_response = JSON.stringify({
- 'error': error,
+ 'type': 'error',
+ 'msg': error,
'pathSegments': pathSegments,
'parameters': parameters
});
« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/bin/vmservice/service_request_router.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698