Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: tests/standalone/vmservice/test_helper.dart

Issue 19870006: Support stacktrace and objecthistogram service commands (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/vmservice/test_helper.dart
diff --git a/tests/standalone/vmservice/test_helper.dart b/tests/standalone/vmservice/test_helper.dart
index 52d1983c44174b40adfd661e06568baae640d296..2ca43e1fb26b509d5fa95d5a162a94407d89220b 100644
--- a/tests/standalone/vmservice/test_helper.dart
+++ b/tests/standalone/vmservice/test_helper.dart
@@ -87,6 +87,7 @@ class TestLauncher {
String dartExecutable = Platform.executable;
return Process.start(dartExecutable,
['--enable-vm-service:0', scriptPath]).then((p) {
+
Completer completer = new Completer();
process = p;
var portNumber;
@@ -112,13 +113,15 @@ class TestLauncher {
process.stderr.transform(new StringDecoder())
.transform(new LineTransformer()).listen((line) {
});
- process.exitCode.then((_) { });
+ process.exitCode.then((code) {
+ Expect.equals(0, code, 'Launched dart executable exited with error.');
+ });
return completer.future;
});
}
void requestExit() {
- process.stdin.add([32]);
+ process.stdin.add([32, 13, 10]);
}
}
@@ -144,14 +147,17 @@ class IsolateListTester {
Expect.isTrue(exists, 'No isolate with id: $id');
}
- void checkIsolateNameContains(String name) {
+ int checkIsolateNameContains(String name) {
var exists = false;
+ int id;
isolateList['members'].forEach((isolate) {
if (isolate['name'].contains(name)) {
exists = true;
+ id = isolate['id'];
}
});
Expect.isTrue(exists, 'No isolate with name: $name');
+ return id;
}
void checkIsolateNamePrefix(int id, String name) {

Powered by Google App Engine
This is Rietveld 408576698