Support stacktrace and objecthistogram service commands

runtime/bin/vmservice/server.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of vmservice;
 
 class Server {
   int port;
   static ContentType jsonContentType = ContentType.parse('application/json');
   final VmService service;
@@ skipping 12 matching lines @@
     if (resource != null) {
       // Serving up a static resource (e.g. .css, .html, .png).
       request.response.headers.contentType = ContentType.parse(mimeType);
       request.response.add(resource.data);
       request.response.close();
       return;
     }
 
     var serviceRequest = new ServiceRequest();
     var r = serviceRequest.parse(request.uri);
+    var f;
     if (!r) {
       // Did not understand the request uri.
       serviceRequest.setErrorResponse('Invalid request uri: ${request.uri}');
     } else {
-      r = service.runningIsolates.route(serviceRequest);
-      if (!r) {
-        // Nothing responds to this type of request.
-        serviceRequest.setErrorResponse('No route for: $path');
-      }
+      f = service.runningIsolates.route(serviceRequest);
     }
 
-    // Send response back over HTTP.
-    request.response.headers.contentType = jsonContentType;
-    request.response.write(serviceRequest.response);
-    request.response.close();
+    if (f == null) {
+      // Nothing responds to this type of request.
+      serviceRequest.setErrorResponse('No route for: $path');

[siva, 2013/08/01 18:16:18]

This seems to override the error response set in the
'if (!r)' block. Maybe you could restructure this code:

if (!r) {
  serviceRequest.setErrorResponse('Invalid request uri: ${request.uri}');
} else {
  var f = service.runningIsolates.route(serviceRequest);
  if (f != null) {
    f.then((_) { ... });
    return;
  }
}
// Send error response back over HTTP.
.....

[Cutch, 2013/08/01 22:22:04]

Done.

+      // Send response back over HTTP.
+      request.response.headers.contentType = jsonContentType;
+      request.response.write(serviceRequest.response);
+      request.response.close();
+      return;
+    }
+
+    // Route was successful.
+    f.then((_) {
+      // Send response back over HTTP.
+      request.response.headers.contentType = jsonContentType;
+      request.response.write(serviceRequest.response);
+      request.response.close();
+    });
   }
 
   Future startServer() {
     return HttpServer.bind(InternetAddress.LOOPBACK_IP_V4, port).then((s) {
       // Only display message when port is automatically selected.
       var display_message = (port == 0);
       // Retrieve port.
       port = s.port;
       _server = s;
       _server.listen(_requestHandler);
       if (display_message) {
         print('VmService listening on port $port');
       }
       return s;
     });
   }
 }
-