Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 1986953003: MacViews: move site settings bubble behind WebUIDialogs feature (Closed)

Created:
4 years, 7 months ago by Elly Fong-Jones
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: move site settings bubble behind WebUIDialogs feature This bubble belongs behind the WebUIDialogs feature with the rest of the MacViews phase 2 dialogs. BUG=535074 Committed: https://crrev.com/9160dc97218a99ac6b3cd1c18cafa16f5fcaf4ae Cr-Commit-Position: refs/heads/master@{#394500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986953003/1
4 years, 7 months ago (2016-05-17 20:43:46 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 22:33:25 UTC) #4
Elly Fong-Jones
rsesek: ptal? :)
4 years, 7 months ago (2016-05-18 13:22:23 UTC) #7
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-18 14:49:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986953003/1
4 years, 7 months ago (2016-05-18 19:18:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 19:23:37 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 19:24:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9160dc97218a99ac6b3cd1c18cafa16f5fcaf4ae
Cr-Commit-Position: refs/heads/master@{#394500}

Powered by Google App Engine
This is Rietveld 408576698