CLI cleanup.

CLI cleanup.

A little linting.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/ff857f1b71cec9716066e4ec089be2b48b7b48c0

[pquitslund, 2016-05-18 12:53:51]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-05-18 14:42:19]

lgtm

https://codereview.chromium.org/1986943002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1986943002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:107: set userDefinedPlugins(List<Plugin>
plugins) {
Personally, I like having "void" for setters. I know that it's five whole extra
characters, but when you follow the rule that everything should be type
annotated, then "void" visually fills in the space where a type would have been
and I find it easier to visually scan the code.

(I don't expect you to agree with me or change this, but wanted you to know that
I disagree with that rule that says that it should be removed so that you
wouldn't take my lgtm to be approval of this kind of change.)

[pquitslund, 2016-05-18 17:26:41]

Thanks!

https://codereview.chromium.org/1986943002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1986943002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:107: set userDefinedPlugins(List<Plugin>
plugins) {
On 2016/05/18 14:42:19, Brian Wilkerson wrote:
> Personally, I like having "void" for setters. I know that it's five whole
extra
> characters, but when you follow the rule that everything should be type
> annotated, then "void" visually fills in the space where a type would have
been
> and I find it easier to visually scan the code.
> 
> (I don't expect you to agree with me or change this, but wanted you to know
that
> I disagree with that rule that says that it should be removed so that you
> wouldn't take my lgtm to be approval of this kind of change.)

Got it.  It should come as no surprise that I tend to prefer eliding the
(gratuitous) void but that hardly matters.  Consistency is far more important. 
Changing back.

[pquitslund, 2016-05-18 17:30:14]

Description was changed from

==========
CLI cleanup.

A little linting.

BUG=
==========

to

==========
CLI cleanup.

A little linting.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ff857f1b71cec9716066e4ec089be2b48b7b48c0
==========

[pquitslund, 2016-05-18 17:30:16]

Committed patchset #1 (id:1) manually as
ff857f1b71cec9716066e4ec089be2b48b7b48c0 (presubmit successful).