content/public/browser/web_contents_observer.h - Issue 1986883002: blimp: Update page load status update indicator to use first paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_observer.h

Issue 1986883002: blimp: Update page load status update indicator to use first paint. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Wez's comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/session/blimp_engine_session.h ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/gpu/queue_message_swap_promise.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents_observer.h

diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h

index 1b8f1996095c2a5fa5fac80b1fe1534f5c14b98e..4eb853d0b5b85aeca56655a9020581cd511ff965 100644

--- a/content/public/browser/web_contents_observer.h

+++ b/content/public/browser/web_contents_observer.h

@@ -318,6 +318,10 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,

// paint after a non-empty layout.

virtual void DidFirstVisuallyNonEmptyPaint() {}

+ // This method is invoked when the main frame in the renderer performs the

nasko 2016/05/24 21:39:22 nit: s/renderer/renderer process/

Khushal 2016/05/26 01:43:00 Done.

+ // first paint after a navigation.

+ virtual void DidFirstPaintAfterLoad(RenderWidgetHost* render_widget_host) {}

// When WebContents::Stop() is called, the WebContents stops loading and then

// invokes this method. If there are ongoing navigations, their respective

// failure methods will also be invoked.