Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1986843003: Add feature for main frame before activation. (Closed)

Created:
4 years, 7 months ago by sunnyps
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, rkaplow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add feature for main frame before activation. This CL adds a feature "MainFrameBeforeActivation" which can be controlled via finch. This CL also moves the MFBA decision to the browser which is based on enable/disable flags, number of cpu cores and finch. The feature is always disabled for devices with fewer than 4 cores. R=piman@chromium.org BUG=612596 Committed: https://crrev.com/3fe3c9880734a233958d7d68750d785daa439835 Cr-Commit-Position: refs/heads/master@{#394281}

Patch Set 1 #

Patch Set 2 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M content/browser/gpu/compositor_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sunnyps
PTAL
4 years, 7 months ago (2016-05-17 21:42:26 UTC) #1
piman
lgtm
4 years, 7 months ago (2016-05-17 21:45:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986843003/20001
4 years, 7 months ago (2016-05-17 22:20:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 00:22:57 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 00:24:47 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3fe3c9880734a233958d7d68750d785daa439835
Cr-Commit-Position: refs/heads/master@{#394281}

Powered by Google App Engine
This is Rietveld 408576698