SkColorSpace follow-ups

SkColorSpace follow-ups

Based on comments from:
https://codereview.chromium.org/1985903002/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1986833002

Committed: https://skia.googlesource.com/skia/+/264f88aff5c2303339c1dbcad02e12f70c62ae72

[msarett, 2016-05-17 17:53:45]

Description was changed from

==========
SkColorSpace follow-ups

Based on comments from:
https://codereview.chromium.org/1985903002/

BUG=skia:
==========

to

==========
SkColorSpace follow-ups

Based on comments from:
https://codereview.chromium.org/1985903002/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-05-17 18:26:23]

msarett@google.com changed reviewers:
+ reed@google.com, scroggo@google.com

[msarett, 2016-05-17 18:26:23]

I wasn't sure between two approaches to making that SkGammaCurves const, so I
uploaded them both:
PS1: const_cast
PS2: New constructor and std::moves

[scroggo, 2016-05-17 19:04:19]

On 2016/05/17 18:26:23, msarett wrote:
> I wasn't sure between two approaches to making that SkGammaCurves const, so I
> uploaded them both:
> PS1: const_cast
> PS2: New constructor and std::moves

Either one lgtm. Slight preference for 2, but in some ways 1 is simpler, and at
least using a const_cast makes it clear that you're doing something dangerous.

[msarett, 2016-05-17 20:26:27]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 20:26:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986833002/20001

[commit-bot: I haz the power, 2016-05-17 20:55:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 20:55:41]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-05-17 20:56:15]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-05-17 20:56:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986833002/20001

[commit-bot: I haz the power, 2016-05-17 20:57:17]

Description was changed from

==========
SkColorSpace follow-ups

Based on comments from:
https://codereview.chromium.org/1985903002/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkColorSpace follow-ups

Based on comments from:
https://codereview.chromium.org/1985903002/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/264f88aff5c2303339c1dbcad02e12f70c62ae72
==========

[commit-bot: I haz the power, 2016-05-17 20:57:18]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/264f88aff5c2303339c1dbcad02e12f70c62ae72