Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 198683002: Make it possible to override the tickmarks for a WebFrame. (Closed)

Created:
6 years, 9 months ago by raymes
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, dglazkov+blink, abarth-chromium, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make it possible to override the tickmarks for a WebFrame. This makes it possible to override the default tickmark behavior for a frame. The default behavior is to display tickmarks for find results. However the PDF plugin handles finding itself but still wants to set tickmarks. This CL makes it possible to specify an array of tickmarks to display. BUG=303491 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169423

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M Source/core/frame/FrameView.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M Source/web/WebFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M public/web/WebFrame.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
raymes
ptal. Thanks!
6 years, 9 months ago (2014-03-13 07:03:22 UTC) #1
jamesr
lgtm, but i think you can add some tests to make sure these map to ...
6 years, 9 months ago (2014-03-13 22:53:05 UTC) #2
raymes
Thanks James! I added the test. Could you please take a quick look at it?
6 years, 9 months ago (2014-03-17 00:31:06 UTC) #3
jamesr
On 2014/03/17 00:31:06, raymes wrote: > Thanks James! I added the test. Could you please ...
6 years, 9 months ago (2014-03-17 05:32:02 UTC) #4
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 9 months ago (2014-03-17 05:45:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/198683002/20001
6 years, 9 months ago (2014-03-17 05:45:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 05:57:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-17 05:57:13 UTC) #8
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 9 months ago (2014-03-18 06:08:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/198683002/40001
6 years, 9 months ago (2014-03-18 06:08:59 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 07:13:49 UTC) #11
Message was sent while issue was closed.
Change committed as 169423

Powered by Google App Engine
This is Rietveld 408576698