Reset user data directory and disk cache directory after downgrade.

chrome/installer/util/install_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/install_util.h"
 
 #include <string>
 #include <utility>
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/test/scoped_path_override.h"
 #include "base/test/test_reg_util_win.h"
 #include "base/win/registry.h"
 #include "chrome/installer/util/google_update_constants.h"
+#include "chrome/installer/util/test_app_registration_data.h"
 #include "chrome/installer/util/work_item.h"
+#include "chrome/installer/util/work_item_list.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::win::RegKey;
 using ::testing::_;
 using ::testing::Return;
 using ::testing::StrEq;
 
 class MockRegistryValuePredicate : public InstallUtil::RegistryValuePredicate {
  public:
   MOCK_CONST_METHOD1(Evaluate, bool(const std::wstring&));
 };
 
+class TestBrowserDistribution : public BrowserDistribution {
+ public:
+  TestBrowserDistribution()
+      : BrowserDistribution(CHROME_BROWSER,
+                            std::unique_ptr<AppRegistrationData>(
+                                new TestAppRegistrationData())) {}
+};
+
 class InstallUtilTest : public testing::Test {
  protected:
   InstallUtilTest() {}
 
   void SetUp() override {
     ResetRegistryOverrides();
   }
 
   void ResetRegistryOverrides() {
     registry_override_manager_.reset(
@@ skipping 467 matching lines @@
 #if defined(_WIN64)
   const int kOtherProgramFilesKey = base::DIR_PROGRAM_FILES;
   base::ScopedPathOverride other_program_files_override(kOtherProgramFilesKey);
   ASSERT_TRUE(PathService::Get(kOtherProgramFilesKey, &some_exe));
   some_exe = some_exe.AppendASCII("Company")
       .AppendASCII("Product")
       .AppendASCII("product.exe");
   EXPECT_TRUE(InstallUtil::IsPerUserInstall(some_exe));
 #endif  // defined(_WIN64)
 }
+
+TEST_F(InstallUtilTest, AddDowngradeVersion) {
+  TestBrowserDistribution dist;
+  bool system_install = true;
+  RegKey(HKEY_LOCAL_MACHINE, dist.GetStateKey().c_str(),
+         KEY_SET_VALUE | KEY_WOW64_32KEY);
+  std::unique_ptr<WorkItemList> list;
+
+  base::Version current_version("1.1.1.1");
+  base::Version higer_new_version("1.1.1.2");
+  base::Version lower_new_version_1("1.1.1.0");
+  base::Version lower_new_version_2("1.1.0.0");
+
+  ASSERT_FALSE(
+      InstallUtil::GetDowngradeVersion(system_install, &dist).IsValid());
+
+  // Upgrade should not create the value.
+  list.reset((WorkItem::CreateWorkItemList()));

[grt (UTC plus 2), 2016/05/20 18:17:05]

nit: remove spurious parens

[zmin, 2016/05/20 19:11:22]

Done.

+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, &current_version, higer_new_version, &dist, list.get());
+  ASSERT_TRUE(list->Do());
+  ASSERT_FALSE(
+      InstallUtil::GetDowngradeVersion(system_install, &dist).IsValid());
+
+  // Downgrade should create the value.
+  list.reset(WorkItem::CreateWorkItemList());
+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, &current_version, lower_new_version_1, &dist, list.get());
+  ASSERT_TRUE(list->Do());
+  EXPECT_EQ(current_version,
+            InstallUtil::GetDowngradeVersion(system_install, &dist));
+
+  // Multiple downgrads should not change the value.

[grt (UTC plus 2), 2016/05/20 18:17:05]

downgrades

[zmin, 2016/05/20 19:11:21]

Done.

+  list.reset(WorkItem::CreateWorkItemList());
+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, &lower_new_version_1, lower_new_version_2, &dist,
+      list.get());
+  ASSERT_TRUE(list->Do());
+  EXPECT_EQ(current_version,
+            InstallUtil::GetDowngradeVersion(system_install, &dist));
+}
+
+TEST_F(InstallUtilTest, DeleteDowngradeVersion) {
+  TestBrowserDistribution dist;
+  bool system_install = true;
+  RegKey(HKEY_LOCAL_MACHINE, dist.GetStateKey().c_str(),
+         KEY_SET_VALUE | KEY_WOW64_32KEY);
+  std::unique_ptr<WorkItemList> list;
+
+  base::Version current_version("1.1.1.1");
+  base::Version higer_new_version("1.1.1.2");
+  base::Version lower_new_version_1("1.1.1.0");
+  base::Version lower_new_version_2("1.1.0.0");
+
+  list.reset(WorkItem::CreateWorkItemList());
+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, &current_version, lower_new_version_2, &dist, list.get());
+  ASSERT_TRUE(list->Do());
+  EXPECT_EQ(current_version,
+            InstallUtil::GetDowngradeVersion(system_install, &dist));
+
+  // Upgrade should not delete the value if it still lower than the version that
+  // downgrade from.
+  list.reset(WorkItem::CreateWorkItemList());
+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, &lower_new_version_2, lower_new_version_1, &dist,
+      list.get());
+  ASSERT_TRUE(list->Do());
+  EXPECT_EQ(current_version,
+            InstallUtil::GetDowngradeVersion(system_install, &dist));
+
+  // Repair should not delete the value.
+  list.reset(WorkItem::CreateWorkItemList());
+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, &lower_new_version_1, lower_new_version_1, &dist,
+      list.get());
+  ASSERT_TRUE(list->Do());
+  EXPECT_EQ(current_version,
+            InstallUtil::GetDowngradeVersion(system_install, &dist));
+
+  // Fully upgrade should delete the value.
+  list.reset(WorkItem::CreateWorkItemList());
+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, &lower_new_version_1, higer_new_version, &dist,
+      list.get());
+  ASSERT_TRUE(list->Do());
+  ASSERT_FALSE(
+      InstallUtil::GetDowngradeVersion(system_install, &dist).IsValid());
+
+  // Fresh install should delete the value if exist

[grt (UTC plus 2), 2016/05/20 18:17:05]

nit: "it exists."

[zmin, 2016/05/20 19:11:21]

Done.

+  list.reset(WorkItem::CreateWorkItemList());
+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, &current_version, lower_new_version_2, &dist, list.get());
+  ASSERT_TRUE(list->Do());
+  EXPECT_EQ(current_version,
+            InstallUtil::GetDowngradeVersion(system_install, &dist));
+  list.reset(WorkItem::CreateWorkItemList());
+  InstallUtil::AddUpdateDowngradeVersionItem(
+      system_install, nullptr, lower_new_version_1, &dist, list.get());
+  ASSERT_TRUE(list->Do());
+  ASSERT_FALSE(
+      InstallUtil::GetDowngradeVersion(system_install, &dist).IsValid());
+}