Reset user data directory and disk cache directory after downgrade.

chrome/installer/util/install_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // See the corresponding header file for description of the functions in this
 // file.
 
 #include "chrome/installer/util/install_util.h"
 
 #include <shellapi.h>
@@ skipping 26 matching lines @@
 #include "chrome/installer/util/installation_state.h"
 #include "chrome/installer/util/l10n_string_util.h"
 #include "chrome/installer/util/util_constants.h"
 #include "chrome/installer/util/work_item_list.h"
 
 using base::win::RegKey;
 using installer::ProductState;
 
 namespace {
 
+const wchar_t kRegDowngradeVersion[] = L"DowngrdeVersion";
 const wchar_t kStageBinaryPatching[] = L"binary_patching";
 const wchar_t kStageBuilding[] = L"building";
 const wchar_t kStageConfiguringAutoLaunch[] = L"configuring_auto_launch";
 const wchar_t kStageCopyingPreferencesFile[] = L"copying_prefs";
 const wchar_t kStageCreatingShortcuts[] = L"creating_shortcuts";
 const wchar_t kStageEnsemblePatching[] = L"ensemble_patching";
 const wchar_t kStageExecuting[] = L"executing";
 const wchar_t kStageFinishing[] = L"finishing";
 const wchar_t kStagePreconditions[] = L"preconditions";
 const wchar_t kStageRefreshingPolicy[] = L"refreshing_policy";
@@ skipping 563 matching lines @@
 }
 
 // Populate |info| for |file|, returning true on success.
 // static
 bool InstallUtil::ProgramCompare::GetInfo(const base::File& file,
                                           BY_HANDLE_FILE_INFORMATION* info) {
   DCHECK(file.IsValid());
   return GetFileInformationByHandle(file.GetPlatformFile(), info) != 0;
 }
 
+// static
+base::Version InstallUtil::GetDowngradeVersion(
+    HKEY root,
+    const BrowserDistribution* dist) {
+  DCHECK(dist);
+  base::win::RegKey key;
+  base::string16 downgrade_version;
+  if (key.Open(root, dist->GetStateKey().c_str(),
+               KEY_QUERY_VALUE | KEY_WOW64_32KEY) != ERROR_SUCCESS ||
+      key.ReadValue(kRegDowngradeVersion, &downgrade_version) !=
+          ERROR_SUCCESS) {
+    return base::Version();
+  }
+  return base::Version(base::UTF16ToASCII(downgrade_version));
+}
+
+// static
+void InstallUtil::AddUpdateDowngradeVersionItem(
+    HKEY root,
+    const base::Version& current_version,
+    const base::Version& new_version,
+    const BrowserDistribution* dist,
+    WorkItemList* list) {
+  DCHECK(list);
+  DCHECK(dist);
+  base::Version downgrade_version = GetDowngradeVersion(root, dist);
+  if (current_version > new_version && !downgrade_version.IsValid()) {
+    list->AddSetRegValueWorkItem(
+        root, dist->GetStateKey(), KEY_WOW64_32KEY, kRegDowngradeVersion,
+        base::ASCIIToUTF16(current_version.GetString()), false);

[grt (UTC plus 2), 2016/05/20 15:25:05]

false -> true since you want to overwrite if there happens to be bogus data in
the value.

[zmin, 2016/05/20 16:33:05]

Done.

+  } else if (current_version < new_version && downgrade_version.IsValid() &&

[grt (UTC plus 2), 2016/05/20 15:25:05]

|downgrade_version| will be invalid if either the value is not present in the
registry, or if it a bogus value is present. i think it's desirable to delete a
bogus value. with that in mind, what do you think about changing this to:
  } else if (current_version < new_version &&
             (!downgrade_version.IsValid() ||
              downgrade_version <= new_version)) {

[zmin, 2016/05/20 16:33:05]

That means for every upgrade(even for the ppl never downgrade chrome), we'll try
to delete a value that never existed. If bogus value is something happened
before for other registry value and the cost of deletion is tiny, I'll agree
with that.

[grt (UTC plus 2), 2016/05/20 18:17:05]

the cost of the delete is insignificant. strange things happen in the registry
on a regular basis, so it's best to be defensive.

+             downgrade_version <= new_version) {
+    list->AddDeleteRegValueWorkItem(root, dist->GetStateKey(), KEY_WOW64_32KEY,
+                                    kRegDowngradeVersion);
+  }
+}
+
 InstallUtil::ProgramCompare::ProgramCompare(const base::FilePath& path_to_match)
     : ProgramCompare(path_to_match, ComparisonType::FILE) {}
 
 InstallUtil::ProgramCompare::ProgramCompare(const base::FilePath& path_to_match,
                                             ComparisonType comparison_type)
     : path_to_match_(path_to_match),
       file_info_(),
       comparison_type_(comparison_type) {
   DCHECK(!path_to_match_.empty());
   if (!OpenForInfo(path_to_match_, &file_, comparison_type_)) {
@@ skipping 38 matching lines @@
 
   // Open the program and see if it references the expected file.
   base::File file;
   BY_HANDLE_FILE_INFORMATION info = {};
 
   return (OpenForInfo(path, &file, comparison_type_) && GetInfo(file, &info) &&
           info.dwVolumeSerialNumber == file_info_.dwVolumeSerialNumber &&
           info.nFileIndexHigh == file_info_.nFileIndexHigh &&
           info.nFileIndexLow == file_info_.nFileIndexLow);
 }