third_party/WebKit/Source/web/ContextMenuClientImpl.h - Issue 1986783002: Text selected with double-tap should not cause vibration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.h

Issue 1986783002: Text selected with double-tap should not cause vibration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the platform macros Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/ContextMenuController.cpp ('K') | « third_party/WebKit/Source/core/page/ContextMenuController.cpp ('k') | third_party/WebKit/Source/web/ContextMenuClientImpl.cpp » ('j') | third_party/WebKit/Source/web/ContextMenuClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ContextMenuClientImpl.h

diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.h b/third_party/WebKit/Source/web/ContextMenuClientImpl.h

index f9b2f5b6c989b5df986b16cbf7c7e752885405d9..313ba1517c216f657a9ff3d176d714fd5b4ae858 100644

--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.h

+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.h

@@ -42,7 +42,7 @@ class ContextMenuClientImpl final : public ContextMenuClient {

public:

explicit ContextMenuClientImpl(WebViewImpl* webView) : m_webView(webView) { }

~ContextMenuClientImpl() override {}

- void showContextMenu(const ContextMenu*) override;

+ bool showContextMenu(const ContextMenu*, bool) override;

aelias_OOO_until_Jul13 2016/05/19 02:25:21 The meaning of this boolean is nonobvious, so it s

amaralp 2016/05/19 18:21:09 Done.

void clearContextMenu() override;

private:

void populateCustomMenuItems(const ContextMenu*, WebContextMenuData*);