content/browser/android/content_view_core_impl.cc - Issue 1986783002: Text selected with double-tap should not cause vibration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 1986783002: Text selected with double-tap should not cause vibration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added description of return value of showContextMenu Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuPopulator.java ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 133cf94055843eb8eab707689b33f4fbc55b9a08..60f68cba2618edbc3886620c03cac9ee6e023910 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -598,6 +598,10 @@ void ContentViewCoreImpl::OnGestureEventAck(const blink::WebGestureEvent& event,

event.x * dpi_scale(),

event.y * dpi_scale());

break;

+ case WebInputEvent::GestureLongPress:

+ if (ack_result == INPUT_EVENT_ACK_STATE_CONSUMED)

+ Java_ContentViewCore_performLongPressHapticFeedback(env, j_obj.obj());

+ break;

default:

break;

}