chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuPopulator.java - Issue 1986783002: Text selected with double-tap should not cause vibration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuPopulator.java

Issue 1986783002: Text selected with double-tap should not cause vibration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added description of return value of showContextMenu Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuPopulator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuPopulator.java

index 26b103d7aa71c1ea0ae3794684c0a8db0f731da8..1b698e694af58a89871dcbb131d30883d56b63a2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuPopulator.java

@@ -13,14 +13,6 @@ import android.view.ContextMenu;

public interface ContextMenuPopulator {

/**

- * Determines whether or not a context menu should be shown for {@code params}.

- * @param params The {@link ContextMenuParams} that represent what should be shown in the

- * context menu.

- * @return Whether or not a context menu should be shown.

- */

- public boolean shouldShowContextMenu(ContextMenuParams params);

- /**

* Should be used to populate {@code menu} with the correct context menu items.

* @param menu The menu to populate.

* @param context A {@link Context} instance.