Text selected with double-tap should not cause vibration

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.app.Activity;
 import android.view.ContextMenu;
 import android.view.ContextMenu.ContextMenuInfo;
-import android.view.HapticFeedbackConstants;
 import android.view.MenuItem;
 import android.view.MenuItem.OnMenuItemClickListener;
 import android.view.View;
 import android.view.View.OnCreateContextMenuListener;
 
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.chrome.browser.share.ShareHelper;
 import org.chromium.content.browser.ContentViewCore;
@@ skipping 34 matching lines @@
 
     /**
      * Starts showing a context menu for {@code view} based on {@code params}.
      * @param contentViewCore The {@link ContentViewCore} to show the menu to.
      * @param params          The {@link ContextMenuParams} that indicate what menu items to show.
      */
     @CalledByNative
     private boolean showContextMenu(ContentViewCore contentViewCore, ContextMenuParams params) {
         final View view = contentViewCore.getContainerView();
 
-        if (!shouldShowMenu(params)
-                || view == null
+        if (view == null
                 || view.getVisibility() != View.VISIBLE
                 || view.getParent() == null) {
             return false;
         }
 
         mCurrentContextMenuParams = params;
 
-        view.performHapticFeedback(HapticFeedbackConstants.LONG_PRESS);
         view.setOnCreateContextMenuListener(this);
         if (view.showContextMenu()) {
             WebContents webContents = contentViewCore.getWebContents();
             RecordHistogram.recordBooleanHistogram(
                     "ContextMenu.Shown", webContents != null);
             if (webContents != null) webContents.onContextMenuOpened();
             return true;
         }
         return false;
     }
@@ skipping 28 matching lines @@
     private void onShareImageReceived(
             WindowAndroid windowAndroid, byte[] jpegImageData) {
         Activity activity = windowAndroid.getActivity().get();
         if (activity == null) return;
 
         ShareHelper.shareImage(activity, jpegImageData);
     }
 
     @Override
     public void onCreateContextMenu(ContextMenu menu, View v, ContextMenuInfo menuInfo) {
-        if (!shouldShowMenu(mCurrentContextMenuParams)) return;
-
         assert mPopulator != null;
         mPopulator.buildContextMenu(menu, v.getContext(), mCurrentContextMenuParams);
 
         for (int i = 0; i < menu.size(); i++) {
             menu.getItem(i).setOnMenuItemClickListener(this);
         }
     }
 
     @Override
     public boolean onMenuItemClick(MenuItem item) {
         return mPopulator.onItemSelected(this, mCurrentContextMenuParams, item.getItemId());
     }
 
     /**
      * @return The {@link ContextMenuPopulator} responsible for populating the context menu.
      */
     @VisibleForTesting
     public ContextMenuPopulator getPopulator() {
         return mPopulator;
     }
 
-    private boolean shouldShowMenu(ContextMenuParams params) {
-        return (mPopulator != null && mPopulator.shouldShowContextMenu(params));
-    }
-
     private native void nativeOnStartDownload(
             long nativeContextMenuHelper, boolean isLink, boolean isDataReductionProxyEnabled);
     private native void nativeSearchForImage(long nativeContextMenuHelper);
     private native void nativeShareImage(long nativeContextMenuHelper);
 }