Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1986763003: Use stricter type checks in Intl's bound methods (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, jungshik at Google
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use stricter type checks in Intl's bound methods This patch ensures that Intl bound method getters can't be retargeted to other Intl types. If that were to happen, then a RUNTIME_ASSERT would trigger later. This patch throws a TypeError instead, as the specification requires. BUG=v8:4870 Committed: https://crrev.com/29bd8286ee98d7ac8524d98e10892f108e814c7b Cr-Commit-Position: refs/heads/master@{#36330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M src/js/i18n.js View 5 chunks +12 lines, -10 lines 0 comments Download
M src/js/intl-extra.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/intl/regress-4870.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986763003/1
4 years, 7 months ago (2016-05-17 21:24:10 UTC) #2
Dan Ehrenberg
4 years, 7 months ago (2016-05-17 21:24:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 21:52:50 UTC) #6
Yang
On 2016/05/17 21:52:50, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-05-18 12:21:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986763003/1
4 years, 7 months ago (2016-05-18 14:50:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 14:55:42 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 14:58:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29bd8286ee98d7ac8524d98e10892f108e814c7b
Cr-Commit-Position: refs/heads/master@{#36330}

Powered by Google App Engine
This is Rietveld 408576698