Issue 1986723003: Remove output from gen-snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1986723003: Remove output from gen-snapshot. (Closed)

Created:
4 years, 7 months ago by floitsch

Modified:
4 years, 7 months ago

Reviewers:
zra, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	runtime/bin/gen_snapshot.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (3 generated)

zra

lgtm +johnmccutchan. That's the only printf in the file. I'm willing to bet it's a ...

4 years, 7 months ago (2016-05-17 15:41:00 UTC) #4

floitsch

4 years, 7 months ago (2016-05-17 15:59:16 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
26250e032225a413509820969b743a6be744b954 (presubmit successful).