Provide option to suppress mirrors metadata

Provide option to suppress mirrors metadata

Fixes #268

Probably too small to affect perf, but I'm looking into adding some more for mirrors and don't want it on by default.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/c963c111db1f68e605f93b63ac437e2da2b610b6

[vsm, 2016-05-17 21:34:05]

Description was changed from

==========
Provide option to suppress mirrors metadata
==========

to

==========
Provide option to suppress mirrors metadata

Fixes #268

Probably too small to affect perf, but I'm looking into adding some more for
mirrors and don't want it on by default.
==========

[vsm, 2016-05-17 21:34:05]

vsm@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com

[Jennifer Messerly, 2016-05-17 21:39:42]

naming suggestion, but LGTM either way!

https://codereview.chromium.org/1986693003/diff/1/lib/src/compiler/compiler.dart
File lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/1986693003/diff/1/lib/src/compiler/compiler.d...
lib/src/compiler/compiler.dart:218: ..addFlag('preserve-annotations',
maybe "emit-metadata" -- slightly shorter?

we also seem to call it "metadata" in some of our docs:
https://www.dartlang.org/docs/dart-up-and-running/ch02.html#summary

(maybe it was to disambiguate "type annotations")

[vsm, 2016-05-17 21:58:14]

On 2016/05/17 21:39:42, John Messerly wrote:
> naming suggestion, but LGTM either way!
> 
>
https://codereview.chromium.org/1986693003/diff/1/lib/src/compiler/compiler.dart
> File lib/src/compiler/compiler.dart (right):
> 
>
https://codereview.chromium.org/1986693003/diff/1/lib/src/compiler/compiler.d...
> lib/src/compiler/compiler.dart:218: ..addFlag('preserve-annotations',
> maybe "emit-metadata" -- slightly shorter?
> 
> we also seem to call it "metadata" in some of our docs:
> https://www.dartlang.org/docs/dart-up-and-running/ch02.html#summary
> 
> (maybe it was to disambiguate "type annotations")

Went with your name.  I also set it to true by default but suppress in the SDK
gen - those annotations are only used by the compiler.

[vsm, 2016-05-17 22:42:34]

Description was changed from

==========
Provide option to suppress mirrors metadata

Fixes #268

Probably too small to affect perf, but I'm looking into adding some more for
mirrors and don't want it on by default.
==========

to

==========
Provide option to suppress mirrors metadata

Fixes #268

Probably too small to affect perf, but I'm looking into adding some more for
mirrors and don't want it on by default.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/c963c111db1f68e605f93b63ac43...
==========

[vsm, 2016-05-17 22:42:36]

Committed patchset #2 (id:20001) manually as
c963c111db1f68e605f93b63ac437e2da2b610b6 (presubmit successful).