Issue 1986683002: Named constants are (usually) not null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1986683002: Named constants are (usually) not null. (Closed)

Created:
4 years, 7 months ago by sra1

Modified:
4 years, 7 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -184 lines)			Patch
M	lib/runtime/dart_sdk.js	View	80 chunks	+171 lines, -171 lines	0 comments	Download
M	lib/src/compiler/nullable_type_inference.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/codegen/expect/fieldtest.js	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	test/codegen/expect/sunflower/sunflower.js	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	test/codegen/expect/sunflower/sunflower.js.map	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

sra1

4 years, 7 months ago (2016-05-17 17:55:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a3be9d1188e89dd0312aee014a608ea267d9c774 (presubmit successful).