Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1986643002: Track pending WebContents and widgets by (process_id, routing_id) pair. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fullscreen-flash
Patch Set: Disable popup menu test for Mac/Android Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index e6f350002cd63cb14e5454802dedf05dd167cf2b..ede10cfe0ba9abd66b13affe40376ed18086b10c 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -2637,9 +2637,10 @@ TEST_F(WebContentsImplTest, PendingContents) {
std::unique_ptr<TestWebContents> other_contents(
static_cast<TestWebContents*>(CreateTestWebContents()));
contents()->AddPendingContents(other_contents.get());
+ int process_id = other_contents->GetRenderViewHost()->GetProcess()->GetID();
int route_id = other_contents->GetRenderViewHost()->GetRoutingID();
other_contents.reset();
- EXPECT_EQ(nullptr, contents()->GetCreatedWindow(route_id));
+ EXPECT_EQ(nullptr, contents()->GetCreatedWindow(process_id, route_id));
}
TEST_F(WebContentsImplTest, CapturerOverridesPreferredSize) {
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/test/data/site_isolation/page-with-select.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698