content/browser/frame_host/interstitial_page_impl.h - Issue 1986643002: Track pending WebContents and widgets by (process_id, routing_id) pair.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl.h

Issue 1986643002: Track pending WebContents and widgets by (process_id, routing_id) pair. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fullscreen-flash

Patch Set: Disable popup menu test for Mac/Android Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/frame_host/interstitial_page_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/interstitial_page_impl.h

diff --git a/content/browser/frame_host/interstitial_page_impl.h b/content/browser/frame_host/interstitial_page_impl.h

index cbefe14f18f9ffea664961b18b5290930f7a9532..d7fc93d4782bcde16073886d07ea0afd89dce3e1 100644

--- a/content/browser/frame_host/interstitial_page_impl.h

+++ b/content/browser/frame_host/interstitial_page_impl.h

@@ -140,12 +140,15 @@ class CONTENT_EXPORT InterstitialPageImpl

blink::WebPopupType popup_type) override;

void CreateNewFullscreenWidget(int32_t render_process_id,

int32_t route_id) override;

- void ShowCreatedWindow(int route_id,

+ void ShowCreatedWindow(int process_id,

+ int route_id,

WindowOpenDisposition disposition,

const gfx::Rect& initial_rect,

bool user_gesture) override;

- void ShowCreatedWidget(int route_id, const gfx::Rect& initial_rect) override;

- void ShowCreatedFullscreenWidget(int route_id) override;

+ void ShowCreatedWidget(int process_id,

+ int route_id,

+ const gfx::Rect& initial_rect) override;

+ void ShowCreatedFullscreenWidget(int process_id, int route_id) override;

SessionStorageNamespace* GetSessionStorageNamespace(

SiteInstance* instance) override;

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/frame_host/interstitial_page_impl.cc » ('j') | no next file with comments »