cloud_print/gcp20/prototype/dns_sd_server.cc - Issue 19866002: GCP2.0 Device: Receiving printjobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/gcp20/prototype/dns_sd_server.cc

Issue 19866002: GCP2.0 Device: Receiving printjobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@confirmation

Patch Set: Unretained -> WeakPtr. Printjob -> PrintJob. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/gcp20/prototype/dns_sd_server.cc

diff --git a/cloud_print/gcp20/prototype/dns_sd_server.cc b/cloud_print/gcp20/prototype/dns_sd_server.cc

index 8a6653f35bd11bdbd9d6d513174301ed1273eb1e..a582e36142a3e5f21c4f91b89c283c1b29010435 100644

--- a/cloud_print/gcp20/prototype/dns_sd_server.cc

+++ b/cloud_print/gcp20/prototype/dns_sd_server.cc

@@ -280,6 +280,7 @@ void DnsSdServer::SendAnnouncement(uint32 ttl) {

base::TimeDelta::FromSeconds(full_ttl_);

// Schedule next announcement.

+ // TODO(maksymb): Replace with weakptr.

base::MessageLoop::current()->PostDelayedTask(

Vitaly Buka (NO REVIEWS) 2013/07/22 23:46:02 ???

maksymb 2013/07/23 00:40:38 Sorry, I've forgot to delete this TODO after resol

FROM_HERE,

base::Bind(&DnsSdServer::Update, AsWeakPtr()),