Fix the browser crash when changing wallpaper with chrome.wallpaper API.

Fix the browser crash when changing wallpaper with chrome.wallpaper API.

The crash is caused by a pointer ownership issue.

BUG=608895
Committed: https://crrev.com/72f2683a0d2175b27d43f8fc91357af138a872c4
Cr-Commit-Position: refs/heads/master@{#394160}

[xdai1, 2016-05-16 22:27:44]

xdai@chromium.org changed reviewers:
+ bshe@chromium.org

[xdai1, 2016-05-16 22:27:45]

Biao, could you help review this CL please? Thanks!

[bshe, 2016-05-16 22:36:40]

On 2016/05/16 22:27:45, xdai1 wrote:
> Biao, could you help review this CL please? Thanks!

Do you mind add a test for it?

[xdai1, 2016-05-17 00:24:34]

On 2016/05/16 22:36:40, bshe wrote:
> On 2016/05/16 22:27:45, xdai1 wrote:
> > Biao, could you help review this CL please? Thanks!
> 
> Do you mind add a test for it?

Test is added. Please take another look, thanks for your review!

[bshe, 2016-05-17 13:44:53]

lgtm with nit

https://codereview.chromium.org/1986583002/diff/20001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/wallpaper/test.js (right):

https://codereview.chromium.org/1986583002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/wallpaper/test.js:88: }
nit: semicolon

[xdai1, 2016-05-17 16:26:23]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2016-05-17 16:26:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1986583002/#ps40001
(title: "Address bshe@'s comment.")

[commit-bot: I haz the power, 2016-05-17 16:26:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986583002/40001

[commit-bot: I haz the power, 2016-05-17 18:00:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-17 18:04:13]

Description was changed from

==========
Fix the browser crash when changing wallpaper with chrome.wallpaper API.

The crash is caused by a pointer ownership issue.

BUG=608895
==========

to

==========
Fix the browser crash when changing wallpaper with chrome.wallpaper API.

The crash is caused by a pointer ownership issue.

BUG=608895

Committed: https://crrev.com/72f2683a0d2175b27d43f8fc91357af138a872c4
Cr-Commit-Position: refs/heads/master@{#394160}
==========

[commit-bot: I haz the power, 2016-05-17 18:04:14]

Patchset 3 (id:??) landed as
https://crrev.com/72f2683a0d2175b27d43f8fc91357af138a872c4
Cr-Commit-Position: refs/heads/master@{#394160}

[qyearsley, 2016-05-17 19:41:46]

On 2016/05/17 at 18:04:14, commit-bot wrote:
> Patchset 3 (id:??) landed as
https://crrev.com/72f2683a0d2175b27d43f8fc91357af138a872c4
> Cr-Commit-Position: refs/heads/master@{#394160}

Possibly related to LSan warning on Linux Chromium OS ASan LSan Tests (1)

Build:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

LeakSanitizer excerpt includes wallpaper_api.cc:
...
==781==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 128 byte(s) in 4 object(s) allocated from:
    #0 0x8fc4fb in operator new(unsigned long)
(/tmp/runnOSzdm/out/Release/browser_tests+0x8fc4fb)
    #1 0x46518c2 in base::BinaryValue::CreateWithCopiedBuffer(char const*,
unsigned long) base/values.cc:329:10
    #2 0x1619fcfb in
WallpaperSetWallpaperFunction::ThumbnailGenerated(base::RefCountedBytes*,
base::RefCountedBytes*)
chrome/browser/chromeos/extensions/wallpaper_api.cc:234:35
    #3 0x46afe8a in Run base/callback.h:397:12
    #4 0x46afe8a in base::debug::TaskAnnotator::RunTask(char const*,
base::PendingTask const&) base/debug/task_annotator.cc:51
    #5 0x4585945 in base::MessageLoop::RunTask(base::PendingTask const&)
base/message_loop/message_loop.cc:478:3
    #6 0x458677b in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask
const&) base/message_loop/message_loop.cc:487:5
    #7 0x458763b in base::MessageLoop::DoWork()
base/message_loop/message_loop.cc:604:13
    #8 0x46a9ed6 in HandleDispatch base/message_loop/message_pump_glib.cc:267:7
    #9 0x46a9ed6 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*,
int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109
    #10 0x7f0c6ca66d12 in g_main_dispatch
/build/buildd/glib2.0-2.32.4/./glib/gmain.c:2539
    #11 0x7f0c6ca66d12 in g_main_context_dispatch
/build/buildd/glib2.0-2.32.4/./glib/gmain.c:3075

...