third_party/WebKit/Source/core/editing/Editor.cpp - Issue 1986563002: Apply vertical-align style of <sub> and <sup> to child elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 1986563002: Apply vertical-align style of <sub> and <sup> to child elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify the test case Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/execCommand/queryCommandState-04.html ('K') | « third_party/WebKit/Source/core/editing/EditingStyle.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 9bbb8311b82095c0192d6efbb1c1d54d32524245..59802d657dad7cea50df6a131b182917d53a621d 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -641,8 +641,10 @@ void Editor::applyParagraphStyleToSelection(StylePropertySet* style, EditAction

bool Editor::selectionStartHasStyle(CSSPropertyID propertyID, const String& value) const

{

- return EditingStyle::create(propertyID, value)->triStateOfStyle(

- EditingStyle::styleAtSelectionStart(frame().selection().selection(), propertyID == CSSPropertyBackgroundColor));

+ EditingStyle* styleToCheck = EditingStyle::create(propertyID, value);

+ EditingStyle* styleAtStart = EditingStyle::styleAtSelectionStart(frame().selection().selection(),

+ propertyID == CSSPropertyBackgroundColor, styleToCheck->style());

+ return styleToCheck->triStateOfStyle(styleAtStart);

}

TriState Editor::selectionHasStyle(CSSPropertyID propertyID, const String& value) const