third_party/WebKit/Source/core/editing/EditingStyle.h - Issue 1986563002: Apply vertical-align style of <sub> and <sup> to child elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingStyle.h

Issue 1986563002: Apply vertical-align style of <sub> and <sup> to child elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify the test case Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/execCommand/queryCommandState-04.html ('K') | « third_party/WebKit/LayoutTests/editing/execCommand/queryCommandState-04.html ('k') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingStyle.h

diff --git a/third_party/WebKit/Source/core/editing/EditingStyle.h b/third_party/WebKit/Source/core/editing/EditingStyle.h

index 1b394a4aab4ae18fd6918377883145a539fa8b56..d2b8baf4ee01b54b3262659e717bc7a2c6dd90c4 100644

--- a/third_party/WebKit/Source/core/editing/EditingStyle.h

+++ b/third_party/WebKit/Source/core/editing/EditingStyle.h

@@ -135,7 +135,7 @@ public:

float fontSizeDelta() const { return m_fontSizeDelta; }

bool hasFontSizeDelta() const { return m_fontSizeDelta != NoFontDelta; }

- static EditingStyle* styleAtSelectionStart(const VisibleSelection&, bool shouldUseBackgroundColorInEffect = false);

+ static EditingStyle* styleAtSelectionStart(const VisibleSelection&, bool shouldUseBackgroundColorInEffect = false, MutableStylePropertySet* styleToCheck = nullptr);

static WritingDirection textDirectionForSelection(const VisibleSelection&, EditingStyle* typingStyle, bool& hasNestedOrMultipleEmbeddings);

static bool isEmbedOrIsolate(CSSValueID unicodeBidi)

{

@@ -163,6 +163,7 @@ private:

Member<MutableStylePropertySet> m_mutableStyle;

bool m_isMonospaceFont;

float m_fontSizeDelta;

+ bool m_isVerticalAlign = false;

friend class HTMLElementEquivalent;

friend class HTMLAttributeEquivalent;