[Media Router WebUI] Import some Polymer elements after initial load.

[Media Router WebUI] Import some Polymer elements after initial load.

Not all of the Polymer elements imported into media-router-container are needed on startup, in particular if they require user interaction to trigger. This change moves some of them to be imported afterNextRender().

It would be great to move everything unused at initial load (e.g. route_details.html), but initial data may return before afterNextRender() is called.

Initial data load times (n=20 runs, Debug build on Mac):
Before: 4.3921s
After: 4.1791s

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/85774de241f2c818a678d490c362e322f6036752
Cr-Commit-Position: refs/heads/master@{#393969}

[apacible, 2016-05-16 20:39:50]

Description was changed from

==========
import later

BUG=
==========

to

==========
import later

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[apacible, 2016-05-16 20:41:19]

Description was changed from

==========
import later

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
import later

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[apacible, 2016-05-16 20:47:00]

Description was changed from

==========
import later

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Import some Polymer elements after initial load.

Not all of the Polymer elements imported into media-router-container are needed
on startup. This change moves some of them to be imported afterNextRender().

It would be great to move everything unused at initial load (e.g.
route_details.html), but initial data may return before afterNextRender() is
called.

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[apacible, 2016-05-16 20:52:43]

Patchset #1 (id:1) has been deleted

[apacible, 2016-05-16 20:57:53]

Description was changed from

==========
[Media Router WebUI] Import some Polymer elements after initial load.

Not all of the Polymer elements imported into media-router-container are needed
on startup. This change moves some of them to be imported afterNextRender().

It would be great to move everything unused at initial load (e.g.
route_details.html), but initial data may return before afterNextRender() is
called.

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Import some Polymer elements after initial load.

Not all of the Polymer elements imported into media-router-container are needed
on startup, in particular if they require user interaction to trigger. This
change moves some of them to be imported afterNextRender().

It would be great to move everything unused at initial load (e.g.
route_details.html), but initial data may return before afterNextRender() is
called.

Initial data load times (n=20 runs, Debug build on Mac):
Before: 4.3921s
After: 4.1791s

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[apacible, 2016-05-16 20:57:53]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-05-16 21:07:42]

PTAL, thanks!

[imcheng, 2016-05-16 22:45:08]

Cool! lgtm

https://codereview.chromium.org/1986543002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(left):

https://codereview.chromium.org/1986543002/diff/20001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:3:
<link rel="import"
href="chrome://resources/polymer/v1_0/neon-animation/web-animations.html">
Where do we use this?

[apacible, 2016-05-16 22:54:41]

https://codereview.chromium.org/1986543002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(left):

https://codereview.chromium.org/1986543002/diff/20001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:3:
<link rel="import"
href="chrome://resources/polymer/v1_0/neon-animation/web-animations.html">
On 2016/05/16 22:45:08, imcheng wrote:
> Where do we use this?

This is used for search/filter.

[apacible, 2016-05-16 22:54:47]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2016-05-16 22:55:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986543002/20001

[commit-bot: I haz the power, 2016-05-16 23:07:49]

Description was changed from

==========
[Media Router WebUI] Import some Polymer elements after initial load.

Not all of the Polymer elements imported into media-router-container are needed
on startup, in particular if they require user interaction to trigger. This
change moves some of them to be imported afterNextRender().

It would be great to move everything unused at initial load (e.g.
route_details.html), but initial data may return before afterNextRender() is
called.

Initial data load times (n=20 runs, Debug build on Mac):
Before: 4.3921s
After: 4.1791s

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Import some Polymer elements after initial load.

Not all of the Polymer elements imported into media-router-container are needed
on startup, in particular if they require user interaction to trigger. This
change moves some of them to be imported afterNextRender().

It would be great to move everything unused at initial load (e.g.
route_details.html), but initial data may return before afterNextRender() is
called.

Initial data load times (n=20 runs, Debug build on Mac):
Before: 4.3921s
After: 4.1791s

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-16 23:07:49]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-05-16 23:09:44]

Description was changed from

==========
[Media Router WebUI] Import some Polymer elements after initial load.

Not all of the Polymer elements imported into media-router-container are needed
on startup, in particular if they require user interaction to trigger. This
change moves some of them to be imported afterNextRender().

It would be great to move everything unused at initial load (e.g.
route_details.html), but initial data may return before afterNextRender() is
called.

Initial data load times (n=20 runs, Debug build on Mac):
Before: 4.3921s
After: 4.1791s

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Import some Polymer elements after initial load.

Not all of the Polymer elements imported into media-router-container are needed
on startup, in particular if they require user interaction to trigger. This
change moves some of them to be imported afterNextRender().

It would be great to move everything unused at initial load (e.g.
route_details.html), but initial data may return before afterNextRender() is
called.

Initial data load times (n=20 runs, Debug build on Mac):
Before: 4.3921s
After: 4.1791s

BUG=549289, 599693
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/85774de241f2c818a678d490c362e322f6036752
Cr-Commit-Position: refs/heads/master@{#393969}
==========

[commit-bot: I haz the power, 2016-05-16 23:09:45]

Patchset 1 (id:??) landed as
https://crrev.com/85774de241f2c818a678d490c362e322f6036752
Cr-Commit-Position: refs/heads/master@{#393969}