Show message center on lock screen

ui/message_center/notification_list.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/notification_list.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 45 matching lines @@
 
 NotificationList::NotificationList()
     : message_center_visible_(false),
       quiet_mode_(false) {
 }
 
 NotificationList::~NotificationList() {
   STLDeleteContainerPointers(notifications_.begin(), notifications_.end());
 }
 
-void NotificationList::SetMessageCenterVisible(
-    bool visible,
+void NotificationList::SetMessageCenterVisible(bool visible) {
+  message_center_visible_ = visible;

[dewittj, 2016/05/19 17:34:03]

This doesn't seem like the right place to track this bit anymore.

[yoshiki, 2016/05/24 17:00:14]

I moved the flag from NotificationList to MessageCenter. I think it's more
natural.

+}
+
+void NotificationList::SetNotificationsShown(

[yoshiki, 2016/05/16 19:04:46]

I splitted this method because I don't want to make notifications read when the
screen is locked.

+    const NotificationBlockers& blockers,

[yoshiki, 2016/05/16 19:04:46]

Adding blockers fixes the bug that this makes blocked notifications read.

     std::set<std::string>* updated_ids) {
-  if (message_center_visible_ == visible)
-    return;
+  Notifications notifications = GetVisibleNotifications(blockers);
 
-  message_center_visible_ = visible;
-
-  if (!visible)
-    return;
-
-  for (Notifications::iterator iter = notifications_.begin();
-       iter != notifications_.end(); ++iter) {
+  for (auto iter = notifications.begin(); iter != notifications.end(); ++iter) {
     Notification* notification = *iter;
     bool was_popup = notification->shown_as_popup();
     bool was_read = notification->IsRead();
     if (notification->priority() < SYSTEM_PRIORITY)
       notification->set_shown_as_popup(true);
     notification->set_is_read(true);
     if (updated_ids && !(was_popup && was_read))
       updated_ids->insert(notification->id());
   }
 }
@@ skipping 260 matching lines @@
     notification->set_shown_as_popup(message_center_visible_
                                      || quiet_mode_
                                      || notification->shown_as_popup());
   }
   // Take ownership. The notification can only be removed from the list
   // in EraseNotification(), which will delete it.
   notifications_.insert(notification.release());
 }
 
 }  // namespace message_center