Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 1986473003: Disable memory.long_running_idle_gmail_background_tbmv2 for WebView (Closed)

Created:
4 years, 7 months ago by Yoland Yan(Google)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable memory.long_running_idle_gmail_background_tbmv2 for WebView BUG=612210 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/32ad946b13471a9091e661bafbba6335522cb010 Cr-Commit-Position: refs/heads/master@{#394008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
Yoland Yan(Google)
4 years, 7 months ago (2016-05-16 18:20:44 UTC) #3
nednguyen
Juan: thoughts?
4 years, 7 months ago (2016-05-16 18:21:13 UTC) #5
nednguyen
lgtm
4 years, 7 months ago (2016-05-16 18:21:31 UTC) #6
Yoland Yan(Google)
On 2016/05/16 18:21:13, nednguyen wrote: > Juan: thoughts? Or should I be changing the story ...
4 years, 7 months ago (2016-05-16 18:23:46 UTC) #7
nednguyen
On 2016/05/16 18:23:46, yolandyan wrote: > On 2016/05/16 18:21:13, nednguyen wrote: > > Juan: thoughts? ...
4 years, 7 months ago (2016-05-16 18:24:35 UTC) #8
Yoland Yan(Google)
On 2016/05/16 18:24:35, nednguyen wrote: > On 2016/05/16 18:23:46, yolandyan wrote: > > On 2016/05/16 ...
4 years, 7 months ago (2016-05-16 18:26:35 UTC) #9
nednguyen
On 2016/05/16 18:26:35, yolandyan wrote: > On 2016/05/16 18:24:35, nednguyen wrote: > > On 2016/05/16 ...
4 years, 7 months ago (2016-05-16 18:26:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986473003/1
4 years, 7 months ago (2016-05-16 18:28:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-16 20:30:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986473003/1
4 years, 7 months ago (2016-05-16 23:38:53 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 01:29:39 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/32ad946b13471a9091e661bafbba6335522cb010 Cr-Commit-Position: refs/heads/master@{#394008}
4 years, 7 months ago (2016-05-17 01:31:03 UTC) #19
perezju
lgtm Btw, Ned, I remember there being some "SupportsTabs" method on the browser? Maybe it ...
4 years, 7 months ago (2016-05-23 10:36:56 UTC) #20
nednguyen
4 years, 7 months ago (2016-05-23 14:35:09 UTC) #21
Message was sent while issue was closed.
On 2016/05/23 10:36:56, perezju (ooo-travelling) wrote:
> lgtm
> 
> Btw, Ned, I remember there being some "SupportsTabs" method on the browser?
> Maybe it could be possible to disable on that?

We have 'has tabs':
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/benchma...

Powered by Google App Engine
This is Rietveld 408576698