|
|
Chromium Code Reviews|
Created:
4 years, 7 months ago by Yoland Yan(Google) Modified:
4 years, 7 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable memory.long_running_idle_gmail_background_tbmv2 for WebView
BUG=612210
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
Committed: https://crrev.com/32ad946b13471a9091e661bafbba6335522cb010
Cr-Commit-Position: refs/heads/master@{#394008}
Patch Set 1 #
Messages
Total messages: 21 (7 generated)
Description was changed from ========== Disable memory.long_running_idle_gmail_background_tbmv2 for WebView BUG=612210 ========== to ========== Disable memory.long_running_idle_gmail_background_tbmv2 for WebView BUG=612210 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
yolandyan@google.com changed reviewers: + mikecase@chromium.org, nednguyen@google.com, rnephew@google.com
nednguyen@google.com changed reviewers: + perezju@chromium.org
Juan: thoughts?
lgtm
On 2016/05/16 18:21:13, nednguyen wrote: > Juan: thoughts? Or should I be changing the story was implemented? Maybe instead of opening a new tab, put the app into background?
On 2016/05/16 18:23:46, yolandyan wrote: > On 2016/05/16 18:21:13, nednguyen wrote: > > Juan: thoughts? > > Or should I be changing the story was implemented? Maybe instead of opening a > new tab, put the app into background? Is disabling this test P1? If not, you can wait for Juan to be back to discuss with him.
On 2016/05/16 18:24:35, nednguyen wrote: > On 2016/05/16 18:23:46, yolandyan wrote: > > On 2016/05/16 18:21:13, nednguyen wrote: > > > Juan: thoughts? > > > > Or should I be changing the story was implemented? Maybe instead of opening a > > new tab, put the app into background? > > Is disabling this test P1? If not, you can wait for Juan to be back to discuss > with him. I think Juan is OOO, I can disable it for now and change it after discussing with him
On 2016/05/16 18:26:35, yolandyan wrote: > On 2016/05/16 18:24:35, nednguyen wrote: > > On 2016/05/16 18:23:46, yolandyan wrote: > > > On 2016/05/16 18:21:13, nednguyen wrote: > > > > Juan: thoughts? > > > > > > Or should I be changing the story was implemented? Maybe instead of opening > a > > > new tab, put the app into background? > > > > Is disabling this test P1? If not, you can wait for Juan to be back to discuss > > with him. > > I think Juan is OOO, I can disable it for now and change it after discussing > with him ok
The CQ bit was checked by yolandyan@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986473003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by yolandyan@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986473003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable memory.long_running_idle_gmail_background_tbmv2 for WebView BUG=612210 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable memory.long_running_idle_gmail_background_tbmv2 for WebView BUG=612210 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/32ad946b13471a9091e661bafbba6335522cb010 Cr-Commit-Position: refs/heads/master@{#394008} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/32ad946b13471a9091e661bafbba6335522cb010 Cr-Commit-Position: refs/heads/master@{#394008}
Message was sent while issue was closed.
lgtm Btw, Ned, I remember there being some "SupportsTabs" method on the browser? Maybe it could be possible to disable on that?
Message was sent while issue was closed.
On 2016/05/23 10:36:56, perezju (ooo-travelling) wrote: > lgtm > > Btw, Ned, I remember there being some "SupportsTabs" method on the browser? > Maybe it could be possible to disable on that? We have 'has tabs': https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/benchma... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
