core/fxcrt/include/fx_system.h - Issue 1986453002: Fix binding of null pointer dereference to reference type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/include/fx_system.h

Issue 1986453002: Fix binding of null pointer dereference to reference type (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use Blink/V8-style IMMEDIATE_CRASH instead" Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/include/fx_system.h

diff --git a/core/fxcrt/include/fx_system.h b/core/fxcrt/include/fx_system.h

index 205976fb15fdb8baff7005cda74cc91595246be5..4cf1ceabef76eff95af50197c2ffd678e3196ed2 100644

--- a/core/fxcrt/include/fx_system.h

+++ b/core/fxcrt/include/fx_system.h

@@ -103,6 +103,14 @@ static_assert(FALSE == false, "false_needs_to_be_false");

#endif

+#ifndef IMMEDIATE_CRASH

Nico 2016/05/16 18:11:29 hm, giving this the same name as blink's macro is

hans 2016/05/16 18:22:18 Done.

+#if defined(__clang__) || defined(__GNUC__)

+#define IMMEDIATE_CRASH() __builtin_trap()

+#else

+#define IMMEDIATE_CRASH() ((void)(*(volatile char*)0 = 0))

+#endif

// M_PI not universally present on all platforms.

#define FX_PI 3.1415926535897932384626433832795f

#define FX_BEZIER 0.5522847498308f

« no previous file with comments | « core/fxcrt/include/fx_basic.h ('k') | no next file » | no next file with comments »