Fix capturing variables in optimized compilations

Fix capturing variables in optimized compilations

Second attempt, this time also capturing hidden variables
like 'this' in initializer lists. Original CL is
https://codereview.chromium.org/1980193002

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/117693961f3494283fe1ec8f2cda9c106b490092

[hausner, 2016-05-17 20:26:08]

Description was changed from

==========
Fix capturing variables in optimized compilations


BUG=
==========

to

==========
Fix capturing variables in optimized compilations

Second attempt, this time also capturing hidden variables
like 'this' in initializer lists.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
==========

[hausner, 2016-05-17 20:27:48]

hausner@google.com changed reviewers:
+ rmacnak@google.com

[hausner, 2016-05-17 20:33:33]

Description was changed from

==========
Fix capturing variables in optimized compilations

Second attempt, this time also capturing hidden variables
like 'this' in initializer lists.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
==========

to

==========
Fix capturing variables in optimized compilations

Second attempt, this time also capturing hidden variables
like 'this' in initializer lists. Original CL is
https://codereview.chromium.org/1980193002

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
==========

[rmacnak, 2016-05-17 21:43:16]

lgtm

[hausner, 2016-05-17 22:59:46]

Description was changed from

==========
Fix capturing variables in optimized compilations

Second attempt, this time also capturing hidden variables
like 'this' in initializer lists. Original CL is
https://codereview.chromium.org/1980193002

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
==========

to

==========
Fix capturing variables in optimized compilations

Second attempt, this time also capturing hidden variables
like 'this' in initializer lists. Original CL is
https://codereview.chromium.org/1980193002

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.

BUG=26453
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/117693961f3494283fe1ec8f2cda9c106b490092
==========

[hausner, 2016-05-17 22:59:47]

Committed patchset #1 (id:1) manually as
117693961f3494283fe1ec8f2cda9c106b490092 (presubmit successful).