SkCanvas::adjustToTopLayer()

SkCanvas::adjustToTopLayer()

Given a matrix and a clip bounds, offsets them to reflect the difference
between device coordinates and global coordinates. Useful when a client
wants an OS-specific backing for a canvas.

R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1986383002

Committed: https://skia.googlesource.com/skia/+/cb3bd18a4b787f6281930dbe49e1c430f28a367c

[tomhudson, 2016-05-17 20:11:05]

Description was changed from

==========
SkCanvas::adjustToTopLayer()

Given a matrix and a clip bounds, offsets them to reflect the difference
between device coordinates and global coordinates. Useful when a client
wants an OS-specific backing for a canvas.

R=reed@google.com
BUG=skia:
==========

to

==========
SkCanvas::adjustToTopLayer()

Given a matrix and a clip bounds, offsets them to reflect the difference
between device coordinates and global coordinates. Useful when a client
wants an OS-specific backing for a canvas.

R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[tomhudson, 2016-05-17 20:11:25]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 20:11:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986383002/1

[commit-bot: I haz the power, 2016-05-17 20:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 20:16:18]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED, no build URL)

[tomhudson, 2016-05-17 20:26:26]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 20:26:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986383002/20001

[commit-bot: I haz the power, 2016-05-17 21:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 21:12:41]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-05-17 21:16:14]

Mike, I think this is what you'd tried writing with the ScopedPlatformPaint /
setMatrixClip() bug...

[reed1, 2016-05-17 23:19:10]

https://codereview.chromium.org/1986383002/diff/20001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/1986383002/diff/20001/include/core/SkCanvas.h...
include/core/SkCanvas.h:1245: void adjustToTopLayer(SkMatrix* matrix, SkIRect*
clip_bounds);
1. temporary_private_adjustToTopLayer(...)
2. perhaps this could just set the two out parameters, rather than just
modifying them? i.e. why have the caller first have to call
getTotalMatrix/getClipDeviceBounds ?

[tomhudson, 2016-05-18 13:16:21]

On 2016/05/17 23:19:10, reed1 wrote:
> https://codereview.chromium.org/1986383002/diff/20001/include/core/SkCanvas.h
> File include/core/SkCanvas.h (right):
> 
>
https://codereview.chromium.org/1986383002/diff/20001/include/core/SkCanvas.h...
> include/core/SkCanvas.h:1245: void adjustToTopLayer(SkMatrix* matrix, SkIRect*
> clip_bounds);
> 1. temporary_private_adjustToTopLayer(...)
> 2. perhaps this could just set the two out parameters, rather than just
> modifying them? i.e. why have the caller first have to call
> getTotalMatrix/getClipDeviceBounds ?

Done.

[tomhudson, 2016-05-18 13:16:26]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 13:16:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986383002/40001

[commit-bot: I haz the power, 2016-05-18 13:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 13:37:33]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-05-18 13:56:57]

lgtm

[tomhudson, 2016-05-18 14:23:09]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2016-05-18 14:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986383002/40001

[commit-bot: I haz the power, 2016-05-18 14:24:18]

Description was changed from

==========
SkCanvas::adjustToTopLayer()

Given a matrix and a clip bounds, offsets them to reflect the difference
between device coordinates and global coordinates. Useful when a client
wants an OS-specific backing for a canvas.

R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkCanvas::adjustToTopLayer()

Given a matrix and a clip bounds, offsets them to reflect the difference
between device coordinates and global coordinates. Useful when a client
wants an OS-specific backing for a canvas.

R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/cb3bd18a4b787f6281930dbe49e1c430f28a367c
==========

[commit-bot: I haz the power, 2016-05-18 14:24:19]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/cb3bd18a4b787f6281930dbe49e1c430f28a367c