xfa/fee/fde_txtedtbuf.cpp - Issue 1986373002: Remove Release() from IFX_CharIter, use unique_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fee/fde_txtedtbuf.cpp

Issue 1986373002: Remove Release() from IFX_CharIter, use unique_ptrs. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fee/fde_txtedtbuf.cpp

diff --git a/xfa/fee/fde_txtedtbuf.cpp b/xfa/fee/fde_txtedtbuf.cpp

index c9ad39252b3ead8241581945385e8c44f894d3fd..def92012e0bc85f2b36130df6addee3675a9cf14 100644

--- a/xfa/fee/fde_txtedtbuf.cpp

+++ b/xfa/fee/fde_txtedtbuf.cpp

@@ -29,10 +29,9 @@ CFDE_TxtEdtBufIter::CFDE_TxtEdtBufIter(CFDE_TxtEdtBuf* pBuf, FX_WCHAR wcAlias)

m_Alias(wcAlias) {

ASSERT(m_pBuf);

}

CFDE_TxtEdtBufIter::~CFDE_TxtEdtBufIter() {}

-void CFDE_TxtEdtBufIter::Release() {

- delete this;

FX_BOOL CFDE_TxtEdtBufIter::Next(FX_BOOL bPrev) {

if (bPrev) {

if (m_nIndex == 0) {