Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1986353002: Revert of [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, oth, Hannes Payer (out of office), ulan, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. (patchset #6 id:170001 of https://codereview.chromium.org/1969423002/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim/builds/619 Might only affect pure release builds? Original issue's description: > [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. > > In order to support compiling to baseline on return we need to be able to > return to the actual return address. With this change this is what the > Return bytecode now does, removing the need for the > InterpreterExitTrampoline. > > This change also removes the InterpreterNotifyDeoptXXX builtins and > unifies FCG and Igntion to both use NotifyDeoptXXX. As part of this > change, FullCodegenerator::State is moved to Deoptimize::BailoutState. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/34c9626e2ee56fe805de549697ca5323aed7cb66 > Cr-Commit-Position: refs/heads/master@{#36288} TBR=mstarzinger@chromium.org,oth@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/c473f2931d83fd8f77c4ea8a57e7f10abec02712 Cr-Commit-Position: refs/heads/master@{#36294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1009 lines, -817 lines) Patch
M src/arm/builtins-arm.cc View 8 chunks +74 lines, -28 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 6 chunks +145 lines, -102 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/deoptimizer.cc View 9 chunks +20 lines, -23 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 49 chunks +58 lines, -74 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 49 chunks +58 lines, -74 lines 0 comments Download
M src/full-codegen/full-codegen.h View 6 chunks +22 lines, -11 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 29 chunks +43 lines, -44 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 50 chunks +58 lines, -74 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 49 chunks +58 lines, -74 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 49 chunks +58 lines, -74 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 50 chunks +58 lines, -74 lines 0 comments Download
M src/heap/heap.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 6 chunks +77 lines, -31 lines 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/interpreter/bytecodes.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/mips/builtins-mips.cc View 6 chunks +73 lines, -29 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 7 chunks +74 lines, -29 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/builtins-x64.cc View 7 chunks +78 lines, -32 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Michael Achenbach
4 years, 7 months ago (2016-05-17 19:43:47 UTC) #1
Created Revert of [Interpreter] Remove InterpreterExitTrampoline and replace
with returning to the entry trampoline.

Powered by Google App Engine
This is Rietveld 408576698