Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1986343002: PPC/S390: Fix %FunctionGetName and %_ClassOf for bound functions. (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/S390: Fix %FunctionGetName and %_ClassOf for bound functions. port 8e303dd0b3d5ded8c91f5982bc565c2edd8c511b R=bmeurer@chromium.org, yangguo@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5010 Committed: https://crrev.com/246d5bba8f8eff204449ecc183a486b9c7722ba5 Cr-Commit-Position: refs/heads/master@{#36323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-17 19:35:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986343002/1
4 years, 7 months ago (2016-05-17 19:36:05 UTC) #3
MTBrandyberry
lgtm
4 years, 7 months ago (2016-05-17 19:54:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 20:04:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986343002/1
4 years, 7 months ago (2016-05-18 13:45:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 13:48:00 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 13:48:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/246d5bba8f8eff204449ecc183a486b9c7722ba5
Cr-Commit-Position: refs/heads/master@{#36323}

Powered by Google App Engine
This is Rietveld 408576698