Motown: Use new TimelineTransform and related definitions

Motown: Use new TimelineTransform and related definitions
1) Deleted rate_control.mojom and replaced with timelines.mojom and
   timeline_controller.mojom.
2) Removed redundant functionality from MediaTimelineController etc.
3) Deleted rate_control_base.* rate control implementation and replaced
   with timeline_control_site.* timeline control site implementation.
4) Moved mojo_publisher from factory_service to common so it can be used
   by timeline_control_site.
5) Updated many dependencies thereof.

R=kulakowski@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6c0e2d583d935eeb5d36360d92741672c996bfa0

[dalesat, 2016-05-17 17:24:40]

Description was changed from

==========
Motown: Use new TimelineTransform and related definitions
1) Deleted rate_control.mojom and replaced with timelines.mojom and
   timeline_controller.mojom.
2) Removed redundant functionality from MediaTimelineController etc.
3) Deleted rate_control_base.* rate control implementation and replaced
   with timeline_control_site.* timeline control site implementation.
4) Moved mojo_publisher from factory_service to common so it can be used
   by timeline_control_site.
5) Updated many dependencies thereof.
==========

to

==========
Motown: Use new TimelineTransform and related definitions
1) Deleted rate_control.mojom and replaced with timelines.mojom and
   timeline_controller.mojom.
2) Removed redundant functionality from MediaTimelineController etc.
3) Deleted rate_control_base.* rate control implementation and replaced
   with timeline_control_site.* timeline control site implementation.
4) Moved mojo_publisher from factory_service to common so it can be used
   by timeline_control_site.
5) Updated many dependencies thereof.
==========

[dalesat, 2016-05-17 17:24:40]

dalesat@chromium.org changed reviewers:
+ kulakowski@chromium.org

[dalesat, 2016-05-17 17:24:54]

Please take a look. Thanks!

[kulakowski, 2016-05-24 13:57:24]

A couple small-ish things, but looks solid! Nice.

https://codereview.chromium.org/1986303002/diff/1/mojo/services/media/common/...
File mojo/services/media/common/cpp/timeline.h (right):

https://codereview.chromium.org/1986303002/diff/1/mojo/services/media/common/...
mojo/services/media/common/cpp/timeline.h:34: return
static_cast<int64_t>(seconds * std::nano::den);
Elsewhere, in code either you or John wrote (I'm sorry I can't find it again in
the ~40 files in the CL), was a comment about std::ratio being verboten,
presumably per the style guide. Did that change? It'd be nice, I think this is a
nice way to canonically give this value without having to count 0s.

https://codereview.chromium.org/1986303002/diff/1/mojo/services/media/common/...
File mojo/services/media/common/cpp/timeline_rate.h (right):

https://codereview.chromium.org/1986303002/diff/1/mojo/services/media/common/...
mojo/services/media/common/cpp/timeline_rate.h:69: :
static_cast<uint32_t>(kFloatFactor * rate_as_float)),
This kFloatFactor feels a bit opaque.

https://codereview.chromium.org/1986303002/diff/1/services/media/common/timel...
File services/media/common/timeline_control_site.h (right):

https://codereview.chromium.org/1986303002/diff/1/services/media/common/timel...
services/media/common/timeline_control_site.h:8: #include <memory>
What's this header used for?

[dalesat, 2016-05-24 18:09:16]

Thanks! PTAL

https://codereview.chromium.org/1986303002/diff/1/mojo/services/media/common/...
File mojo/services/media/common/cpp/timeline.h (right):

https://codereview.chromium.org/1986303002/diff/1/mojo/services/media/common/...
mojo/services/media/common/cpp/timeline.h:34: return
static_cast<int64_t>(seconds * std::nano::den);
On 2016/05/24 13:57:24, kulakowski wrote:
> Elsewhere, in code either you or John wrote (I'm sorry I can't find it again
in
> the ~40 files in the CL), was a comment about std::ratio being verboten,
> presumably per the style guide. Did that change? It'd be nice, I think this is
a
> nice way to canonically give this value without having to count 0s.

Yes, I remember that, too, but I can't find it. I felt OK about using these
here, because John used them in local_time.h, a file with similar scope of
concerns. I can certainly change this, but I frankly don't see the harm in using
these definitions.

https://codereview.chromium.org/1986303002/diff/1/mojo/services/media/common/...
File mojo/services/media/common/cpp/timeline_rate.h (right):

https://codereview.chromium.org/1986303002/diff/1/mojo/services/media/common/...
mojo/services/media/common/cpp/timeline_rate.h:69: :
static_cast<uint32_t>(kFloatFactor * rate_as_float)),
On 2016/05/24 13:57:24, kulakowski wrote:
> This kFloatFactor feels a bit opaque.

Added comments.

https://codereview.chromium.org/1986303002/diff/1/services/media/common/timel...
File services/media/common/timeline_control_site.h (right):

https://codereview.chromium.org/1986303002/diff/1/services/media/common/timel...
services/media/common/timeline_control_site.h:8: #include <memory>
On 2016/05/24 13:57:24, kulakowski wrote:
> What's this header used for?

Nothing, apparently. Removed.

[kulakowski, 2016-05-24 18:11:04]

lgtm

[dalesat, 2016-05-24 18:14:34]

Description was changed from

==========
Motown: Use new TimelineTransform and related definitions
1) Deleted rate_control.mojom and replaced with timelines.mojom and
   timeline_controller.mojom.
2) Removed redundant functionality from MediaTimelineController etc.
3) Deleted rate_control_base.* rate control implementation and replaced
   with timeline_control_site.* timeline control site implementation.
4) Moved mojo_publisher from factory_service to common so it can be used
   by timeline_control_site.
5) Updated many dependencies thereof.
==========

to

==========
Motown: Use new TimelineTransform and related definitions
1) Deleted rate_control.mojom and replaced with timelines.mojom and
   timeline_controller.mojom.
2) Removed redundant functionality from MediaTimelineController etc.
3) Deleted rate_control_base.* rate control implementation and replaced
   with timeline_control_site.* timeline control site implementation.
4) Moved mojo_publisher from factory_service to common so it can be used
   by timeline_control_site.
5) Updated many dependencies thereof.

R=kulakowski@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/6c0e2d583d935eeb5d36360d927...
==========

[dalesat, 2016-05-24 18:14:35]

Committed patchset #2 (id:20001) manually as
6c0e2d583d935eeb5d36360d92741672c996bfa0 (presubmit successful).