Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5268)

Unified Diff: chrome/common/extensions/api/downloads.idl

Issue 19863005: Warn users about potentially unwanted downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/downloads.idl
diff --git a/chrome/common/extensions/api/downloads.idl b/chrome/common/extensions/api/downloads.idl
index af6eac15c19f965681d6178197bef9d32e4b54a8..877d65542e1db61414691eefb286e6564b292435 100644
--- a/chrome/common/extensions/api/downloads.idl
+++ b/chrome/common/extensions/api/downloads.idl
@@ -76,12 +76,14 @@ namespace downloads {
// <dt>host</dt>
// <dd>The download came from a host known to distribute malicious
// binaries and is likely dangerous.</dd>
+ // <dt>unwanted</dt>
benjhayden 2013/07/22 20:16:19 "unwanted" is very vague. How about "modifiesSetti
asanka 2013/07/23 15:10:36 This is intentionally vague. Chrome gets this sign
+ // <dd>The download could make changes to browser or system settings.</dd>
// <dt>safe</dt>
// <dd>The download presents no known danger to the user's computer.</dd>
// <dt>accepted</dt>
// <dd>The user has accepted the dangerous download.</dd>
// </dl>
- enum DangerType {file, url, content, uncommon, host, safe, accepted};
+ enum DangerType {file, url, content, uncommon, host, unwanted, safe, accepted};
// <dl><dt>in_progress</dt>
// <dd>The download is currently receiving data from the server.</dd>

Powered by Google App Engine
This is Rietveld 408576698