PNaCl on-demand installs: Make a separate async IPC to check if PNaCl is installed

chrome/browser/nacl_host/nacl_file_host.h

Index: chrome/browser/nacl_host/nacl_file_host.h
diff --git a/chrome/browser/nacl_host/nacl_file_host.h b/chrome/browser/nacl_host/nacl_file_host.h
index ee473cc3de0ab941e04f8a1b238a1ae3f4a9cade..560091152a0e76c9a7d836940a5698ff9ab6e40c 100644
--- a/chrome/browser/nacl_host/nacl_file_host.h
+++ b/chrome/browser/nacl_host/nacl_file_host.h
@@ -7,6 +7,7 @@
 
 #include <string>
 
+#include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 
@@ -25,8 +26,19 @@ class Message;
 // Opens NaCl Files in the Browser process, on behalf of the NaCl plugin.
 
 namespace nacl_file_host {
-
-// Open a Pnacl file (readonly) on behalf of the NaCl plugin.
+typedef base::Callback<void(bool)> InstallCallback;
+typedef base::Callback<void(int64, int64)> InstallProgressCallback;

[dmichael (off chromium), 2013/08/01 17:33:49]

I think you ought to document here what those int64 values are. Or to make it
self-documenting, make a little InstallProgress struct that contains the two
values as named attributes instead.

[jvoung (off chromium), 2013/08/02 18:32:36]

Done.

+
+// Ensure that PNaCl is installed.  Calls |done_callback| if PNaCl is already
+// installed.  Otherwise, issues a request to install and calls |done_callback|
+// after that request completes w/ success or failure.
+// If an request to install is issued, then |progress_callback| is called

[dmichael (off chromium), 2013/08/01 17:33:49]

s/an/a

[jvoung (off chromium), 2013/08/01 23:14:07]

Done.

+// with progress updates.
+void EnsurePnaclInstalled(
+    const InstallCallback& done_callback,
+    const InstallProgressCallback& progress_callback);
+
+// Open a PNaCl file (readonly) on behalf of the NaCl plugin.
 void GetReadonlyPnaclFd(
     scoped_refptr<NaClHostMessageFilter> nacl_host_message_filter,
     const std::string& filename,