Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1986263003: [Win] Implement deviceorientationabsolute data fetcher. (Closed)

Created:
4 years, 7 months ago by timvolodine
Modified:
4 years, 7 months ago
CC:
chromium-reviews, riju_, Michael van Ouwerkerk, jam, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win] Implement deviceorientationabsolute data fetcher. Implement deviceorientationabsolute according to specification on the Windows platform. spec: https://w3c.github.io/deviceorientation/spec-source-orientation.html TEST=https://timvolodine.github.io/deviceorientation-test/ BUG=612776 Committed: https://crrev.com/14e071cebff88424a7fce22a900a2d45f82f7b40 Cr-Commit-Position: refs/heads/master@{#394752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M content/browser/device_sensors/data_fetcher_shared_memory.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_win.cc View 5 chunks +32 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
timvolodine
4 years, 7 months ago (2016-05-17 18:29:30 UTC) #2
Michael van Ouwerkerk
lgtm but please add a bug number if you have one :-)
4 years, 7 months ago (2016-05-18 09:46:07 UTC) #3
timvolodine
On 2016/05/18 09:46:07, Michael van Ouwerkerk wrote: > lgtm but please add a bug number ...
4 years, 7 months ago (2016-05-18 11:23:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986263003/1
4 years, 7 months ago (2016-05-19 11:13:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 13:08:44 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 13:10:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14e071cebff88424a7fce22a900a2d45f82f7b40
Cr-Commit-Position: refs/heads/master@{#394752}

Powered by Google App Engine
This is Rietveld 408576698