Issue 1986243002: Fix Iterable.where documentation by updating its signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1986243002: Fix Iterable.where documentation by updating its signature. (Closed)

Created:
4 years, 7 months ago by floitsch

Modified:
4 years, 7 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix Iterable.where documentation by updating its signature. Fixes #26459 BUG= http://dartbug.com/26459 Committed: https://github.com/dart-lang/sdk/commit/1be2f872368f4ef3a25034442411e94fa169a715

Patch Set 1 #

Total comments: 1

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sdk/lib/core/iterable.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

Committed patchset #1 (id:1) manually as 1be2f872368f4ef3a25034442411e94fa169a715 (presubmit successful).

4 years, 7 months ago (2016-05-17 15:57:18 UTC) #4

Lasse Reichstein Nielsen

4 years, 7 months ago (2016-05-17 18:28:23 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1986243002/diff/1/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/1986243002/diff/1/sdk/lib/core/iterable.dart#...
sdk/lib/core/iterable.dart:173: new WhereIterable<E>(this, test);
Are you sure it didn't fit one one line?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages