Do timer allocation and string building outside of bench loops

bench/TimerData.h

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef TimerData_DEFINED
 #define TimerData_DEFINED
 
 #include "SkString.h"
+#include "SkTemplates.h"
+
 
 class BenchTimer;
 
 class TimerData {
 public:
-    TimerData(const SkString& perIterTimeFormat, const SkString& normalTimeFormat);
+    /**
+     * Constructs a TimerData to hold at most maxNumTimings sets of elapsed timer values.
+     **/
+    explicit TimerData(int maxNumTimings);
 
     /**
-     * Append the value from each timer in BenchTimer to our various strings, and update the
-     * minimum and sum times.
+     * Collect times from the BenchTimer for an iteration. It will fail if called more often than
+     * indicated in the constructor.
+     *
      * @param BenchTimer Must not be null.
-     * @param last True if this is the last set of times to add.
      */
-    void appendTimes(BenchTimer*, bool last);
-    SkString getResult(bool logPerIter, bool printMin, int repeatDraw, const char* configName,
-                       bool showWallTime, bool showTruncatedWallTime, bool showCpuTime,
-                       bool showTruncatedCpuTime, bool showGpuTime);
+    bool appendTimes(BenchTimer*);

[scroggo, 2013/07/30 19:12:34]

This boolean result is never used.

[bsalomon, 2013/07/31 15:21:39]

I put SkAssertResult around the callers.

+
+    enum Result {
+        kMin_Result,
+        kAvg_Result,
+        kPerIter_Result
+    };
+
+    enum TimerFlags {
+        kWall_Flag              = 0x1,
+        kTruncatedWall_Flag     = 0x2,
+        kCpu_Flag               = 0x4,
+        kTruncatedCpu_Flag      = 0x8,
+        kGpu_Flag               = 0x10
+    };
+
+    SkString getResult(const char* doubleFormat,
+                       Result result,
+                       const char* configName,
+                       uint32_t timerFlags,
+                       int itersPerTiming = 1);

[scroggo, 2013/07/30 19:12:34]

Could you add a comment explaining itersPerTiming? It seems it is only used for
longRunningTimer, which is (and was, before this CL) a bit of a hack.

[bsalomon, 2013/07/31 15:21:39]

Done.

 private:
-    SkString fWallStr;
-    SkString fTruncatedWallStr;
-    SkString fCpuStr;
-    SkString fTruncatedCpuStr;
-    SkString fGpuStr;
-    double fWallSum, fWallMin;
-    double fTruncatedWallSum, fTruncatedWallMin;
-    double fCpuSum, fCpuMin;
-    double fTruncatedCpuSum, fTruncatedCpuMin;
-    double fGpuSum, fGpuMin;
+    int fMaxNumTimings;
+    int fCurrTiming;
 
-    SkString fPerIterTimeFormat;
-    SkString fNormalTimeFormat;
+    SkAutoTArray<double> fWallTimes;
+    SkAutoTArray<double> fTruncatedWallTimes;
+    SkAutoTArray<double> fCpuTimes;
+    SkAutoTArray<double> fTruncatedCpuTimes;
+    SkAutoTArray<double> fGpuTimes;
 };
 
 #endif // TimerData_DEFINED