Issue 1986193002: Fix bug in QUIC SCUP message generation in which the client nonce was used in place of the CHLO has…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1986193002: Fix bug in QUIC SCUP message generation in which the client nonce was used in place of the CHLO has… (Closed)

Created:
4 years, 7 months ago by danzh1

Modified:
4 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@121962941

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix bug in QUIC SCUP message generation in which the client nonce was used in place of the CHLO hash when generating the proof. Merge internal change: 121980704 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -7 lines)			Patch
M	net/quic/crypto/quic_crypto_server_config.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_server_config.cc	View	2 chunks	+17 lines, -6 lines	0 comments	Download
M	net/quic/quic_crypto_server_stream.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_crypto_server_stream.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	net/quic/quic_crypto_server_stream_test.cc	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1984243002 Patch 1

Dependent Patchsets:

Issue 1988793002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages