Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: net/quic/quic_sent_packet_manager_test.cc

Issue 1986183002: Remove GetRttStats from QuicSentPacketManagerPeer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@121941143
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flow_controller_test.cc ('k') | net/quic/test_tools/quic_sent_packet_manager_peer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager_test.cc
diff --git a/net/quic/quic_sent_packet_manager_test.cc b/net/quic/quic_sent_packet_manager_test.cc
index b44334090a9fc9a9587c5a26f7d4f0e189f35461..6b8f96e50adff54a99cac201294d788f239a7338 100644
--- a/net/quic/quic_sent_packet_manager_test.cc
+++ b/net/quic/quic_sent_packet_manager_test.cc
@@ -651,8 +651,7 @@ TEST_P(QuicSentPacketManagerTest, Rtt) {
QuicAckFrame ack_frame = InitAckFrame(packet_number);
ack_frame.ack_delay_time = QuicTime::Delta::FromMilliseconds(5);
manager_.OnIncomingAck(ack_frame, clock_.Now());
- EXPECT_EQ(expected_rtt,
- QuicSentPacketManagerPeer::GetRttStats(&manager_)->latest_rtt());
+ EXPECT_EQ(expected_rtt, manager_.GetRttStats()->latest_rtt());
}
TEST_P(QuicSentPacketManagerTest, RttWithInvalidDelta) {
@@ -668,8 +667,7 @@ TEST_P(QuicSentPacketManagerTest, RttWithInvalidDelta) {
QuicAckFrame ack_frame = InitAckFrame(packet_number);
ack_frame.ack_delay_time = QuicTime::Delta::FromMilliseconds(11);
manager_.OnIncomingAck(ack_frame, clock_.Now());
- EXPECT_EQ(expected_rtt,
- QuicSentPacketManagerPeer::GetRttStats(&manager_)->latest_rtt());
+ EXPECT_EQ(expected_rtt, manager_.GetRttStats()->latest_rtt());
}
TEST_P(QuicSentPacketManagerTest, RttWithInfiniteDelta) {
@@ -684,8 +682,7 @@ TEST_P(QuicSentPacketManagerTest, RttWithInfiniteDelta) {
QuicAckFrame ack_frame = InitAckFrame(packet_number);
ack_frame.ack_delay_time = QuicTime::Delta::Infinite();
manager_.OnIncomingAck(ack_frame, clock_.Now());
- EXPECT_EQ(expected_rtt,
- QuicSentPacketManagerPeer::GetRttStats(&manager_)->latest_rtt());
+ EXPECT_EQ(expected_rtt, manager_.GetRttStats()->latest_rtt());
}
TEST_P(QuicSentPacketManagerTest, RttZeroDelta) {
@@ -700,8 +697,7 @@ TEST_P(QuicSentPacketManagerTest, RttZeroDelta) {
QuicAckFrame ack_frame = InitAckFrame(packet_number);
ack_frame.ack_delay_time = QuicTime::Delta::Zero();
manager_.OnIncomingAck(ack_frame, clock_.Now());
- EXPECT_EQ(expected_rtt,
- QuicSentPacketManagerPeer::GetRttStats(&manager_)->latest_rtt());
+ EXPECT_EQ(expected_rtt, manager_.GetRttStats()->latest_rtt());
}
TEST_P(QuicSentPacketManagerTest, TailLossProbeTimeout) {
@@ -1189,7 +1185,7 @@ TEST_P(QuicSentPacketManagerTest, GetTransmissionTimeCryptoHandshake) {
SendCryptoPacket(1);
// Check the min.
- RttStats* rtt_stats = QuicSentPacketManagerPeer::GetRttStats(&manager_);
+ RttStats* rtt_stats = const_cast<RttStats*>(manager_.GetRttStats());
rtt_stats->set_initial_rtt_us(1 * kNumMicrosPerMilli);
EXPECT_EQ(clock_.Now().Add(QuicTime::Delta::FromMilliseconds(10)),
manager_.GetRetransmissionTime());
@@ -1218,7 +1214,7 @@ TEST_P(QuicSentPacketManagerTest, GetTransmissionTimeTailLossProbe) {
SendDataPacket(2);
// Check the min.
- RttStats* rtt_stats = QuicSentPacketManagerPeer::GetRttStats(&manager_);
+ RttStats* rtt_stats = const_cast<RttStats*>(manager_.GetRttStats());
rtt_stats->set_initial_rtt_us(1 * kNumMicrosPerMilli);
EXPECT_EQ(clock_.Now().Add(QuicTime::Delta::FromMilliseconds(10)),
manager_.GetRetransmissionTime());
@@ -1251,10 +1247,9 @@ TEST_P(QuicSentPacketManagerTest, GetTransmissionTimeTailLossProbe) {
}
TEST_P(QuicSentPacketManagerTest, GetTransmissionTimeSpuriousRTO) {
- QuicSentPacketManagerPeer::GetRttStats(&manager_)
+ const_cast<RttStats*>(manager_.GetRttStats())
->UpdateRtt(QuicTime::Delta::FromMilliseconds(100),
QuicTime::Delta::Zero(), QuicTime::Zero());
-
SendDataPacket(1);
SendDataPacket(2);
SendDataPacket(3);
@@ -1710,7 +1705,7 @@ TEST_P(QuicSentPacketManagerTest, ResumeConnectionState) {
}
TEST_P(QuicSentPacketManagerTest, ConnectionMigrationUnspecifiedChange) {
- RttStats* rtt_stats = QuicSentPacketManagerPeer::GetRttStats(&manager_);
+ RttStats* rtt_stats = const_cast<RttStats*>(manager_.GetRttStats());
int64_t default_init_rtt = rtt_stats->initial_rtt_us();
rtt_stats->set_initial_rtt_us(default_init_rtt * 2);
EXPECT_EQ(2 * default_init_rtt, rtt_stats->initial_rtt_us());
@@ -1729,7 +1724,7 @@ TEST_P(QuicSentPacketManagerTest, ConnectionMigrationUnspecifiedChange) {
}
TEST_P(QuicSentPacketManagerTest, ConnectionMigrationIPSubnetChange) {
- RttStats* rtt_stats = QuicSentPacketManagerPeer::GetRttStats(&manager_);
+ RttStats* rtt_stats = const_cast<RttStats*>(manager_.GetRttStats());
int64_t default_init_rtt = rtt_stats->initial_rtt_us();
rtt_stats->set_initial_rtt_us(default_init_rtt * 2);
EXPECT_EQ(2 * default_init_rtt, rtt_stats->initial_rtt_us());
@@ -1747,7 +1742,7 @@ TEST_P(QuicSentPacketManagerTest, ConnectionMigrationIPSubnetChange) {
}
TEST_P(QuicSentPacketManagerTest, ConnectionMigrationPortChange) {
- RttStats* rtt_stats = QuicSentPacketManagerPeer::GetRttStats(&manager_);
+ RttStats* rtt_stats = const_cast<RttStats*>(manager_.GetRttStats());
int64_t default_init_rtt = rtt_stats->initial_rtt_us();
rtt_stats->set_initial_rtt_us(default_init_rtt * 2);
EXPECT_EQ(2 * default_init_rtt, rtt_stats->initial_rtt_us());
« no previous file with comments | « net/quic/quic_flow_controller_test.cc ('k') | net/quic/test_tools/quic_sent_packet_manager_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698