Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1986173004: Remove more unused bailout reasons. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove more unused bailout reasons. There's a script for finding them (tools/check-unused-bailouts.sh), but make sure you don't have an old .bailout-reason.h.swp or such around when using it... R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/2123afff52fdad40e61d8449a6c90ee6cacbee89 Cr-Commit-Position: refs/heads/master@{#36287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M src/bailout-reason.h View 8 chunks +0 lines, -10 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 7 months ago (2016-05-17 15:29:42 UTC) #1
Michael Starzinger
LGTM. Thanks!
4 years, 7 months ago (2016-05-17 15:40:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986173004/1
4 years, 7 months ago (2016-05-17 15:41:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 16:12:33 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 16:13:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2123afff52fdad40e61d8449a6c90ee6cacbee89
Cr-Commit-Position: refs/heads/master@{#36287}

Powered by Google App Engine
This is Rietveld 408576698