Fixes that host restriction was sometimes applied even when switched off.

components/ntp_snippets/ntp_snippets_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/ntp_snippets_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <utility>
 
@@ skipping 168 matching lines @@
 void NTPSnippetsService::RegisterProfilePrefs(PrefRegistrySimple* registry) {
   registry->RegisterListPref(prefs::kSnippets);
   registry->RegisterListPref(prefs::kDiscardedSnippets);
   registry->RegisterListPref(prefs::kSnippetHosts);
 }
 
 void NTPSnippetsService::Init(bool enabled) {
   enabled_ = enabled;
   if (enabled_) {
     // |suggestions_service_| can be null in tests.
-    if (suggestions_service_) {
+    if (snippets_fetcher_->UseHostRestriction() && suggestions_service_) {

[Marc Treib, 2016/05/17 15:23:58]

Should we (in another CL) make UseHostRestriction (and similarly
UseAuthentication) static, to make it a bit clearer that they can never change
at runtime?

[jkrcal, 2016/05/18 08:30:39]

I agree, in a separate CL.
Heh, I've forgotten to make them public in first place :) I was puzzled because
I did it in https://codereview.chromium.org/1978513002/. I took over all changes
in ntp_snippets_fetcher.h from there to make merging easier.

       suggestions_service_subscription_ = suggestions_service_->AddCallback(
           base::Bind(&NTPSnippetsService::OnSuggestionsChanged,
                      base::Unretained(this)));
     }
 
     // Get any existing snippets immediately from prefs.
     LoadDiscardedSnippetsFromPrefs();
     LoadSnippetsFromPrefs();
 
     // If we don't have any snippets yet, start a fetch.
@@ skipping 298 matching lines @@
     if (snippet->expiry_date() < next_expiry)
       next_expiry = snippet->expiry_date();
   }
   DCHECK_GT(next_expiry, expiry);
   expiry_timer_.Start(FROM_HERE, next_expiry - expiry,
                       base::Bind(&NTPSnippetsService::LoadingSnippetsFinished,
                                  base::Unretained(this)));
 }
 
 }  // namespace ntp_snippets